Update MobX icon #7229
Merged
Update MobX icon #7229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix vertical centering of MobX icon
github-actions
bot
added
the
update icon/data
sachinraja
approved these changes
Mar 18, 2022
|
Good catch! |
mondeja
added a commit
that referenced
this pull request
Mar 20, 2022
# New Icons - AWS Lambda (#6907) - Chemex (#4792) - ClickHouse (#6854) - CoinMarketCap (#5205) - Conventional Commits (#7200) - CrateDB (#7237) - Dask (#7210) - DVC (#7221) - GNOME Terminal (#5690) - Grand Frais (#6490) - K3s (#6851) - Lens (#6853) - Linkerd (#7230) - Liquibase (#7232) - Matter.js (#6508) - ONLYOFFICE (#7192) - OpenSearch (#7207) - Poetry (#7223) - Soundcharts (#7225) - Stardock (#7205) - Supermicro (#4659) # Updated Icons - Ajv (#6508) - Alacritty (#6508) - Amazon DynamoDB (#7233) - Amazon Fire TV (#7233) - Amazon Lumberyard (#7233) - Amazon Pay (#7233) - Amazon S3 (#7233) - AMD (#7233) - AWS Amplify (#7233) - GitLab (#7234) - GNOME (#5690) - MobX (#7229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: n/a
GitHub Stars: 25k
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
In the previous version of the MobX icon, the text component was not vertically centered correctly. The problem was not detected by
svglintbecause the text component is contained in a box, so the overall shape was centered. I've fixed the alignment with a minimal diff of the SVG path data.