Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swiggy #4875

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Add Swiggy #4875

merged 3 commits into from
Feb 24, 2021

Conversation

adamalston
Copy link
Contributor

swiggy

Closes #3951

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Source is the company that created the icon

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 26, 2021
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamalston!
I've mentioned it below, but it's always worth linking directly to the brand as opposed to an agency that created the logo on their behalf. Should they rebrand and go with a different agency, we're less likely to see a change on the agency's site.

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/swiggy.svg Outdated Show resolved Hide resolved
@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @adamalston?

@adamrusted
Copy link
Member

@PeterShaggyNoble I've just pushed the path I used for comparison. If you could review this one, we could look to getting it merged in 👌

@hasthamalp
Copy link

it is merged?

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks perfect to me - nice work, @adamalston & @adamrusted 👍 Going to update the source URL and then merge this in.

@PeterShaggyNoble PeterShaggyNoble merged commit 4887643 into simple-icons:develop Feb 24, 2021
ericcornelissen added a commit that referenced this pull request Feb 28, 2021
# New Icons

- AirAsia (#4892)
- AMP (#4962)
- Amul (#4955)
- Apostrophe (#4977)
- Apple Arcade (#4944)
- AssemblyScript (#4997)
- AutoHotkey (#4911)
- Baremetrics (#5118)
- Bitwig (#4958)
- CBS (#5122)
- Etihad Airways (#4957)
- Grammarly (#5045)
- KakaoTalk (#5016)
- Kasa Smart (#5114)
- KnowledgeBase (#4922)
- Max (#4981)
- MyAnimeList (#4718)
- Namebase (#5074)
- Nano (#5063)
- Nx (#4860)
- PlayCanvas (#5103)
- Plotly (#5111)
- Ram (#5014)
- reveal.js (#5127)
- Rezgo (#5100)
- S7 Airlines (#4888)
- Supabase (#4858)
- SurveyMonkey (#4790)
- SUSE (#4905)
- Swiggy (#4875)
- ts-node (#5105)
- Vaadin (#5007)

# Updated Icons

- Chrysler (#4991)
- Fiat (#5008)
- Jeep (#5011)
- Peugeot (#5119)
- Vauxhall (#5015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Swiggy Icon
4 participants