Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pytest icon #5871

Merged
merged 7 commits into from Jun 15, 2021
Merged

Conversation

DenverCoder1
Copy link
Contributor

image

Issue: Resolves #5474
Website: https://pytest.org, https://github.com/pytest-dev/pytest
Alexa rank: 174,236

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The blue color was chosen as the color since it is the color of the largest bar as well as being incorporated as the text color in the text version of the logo.

The SVG from the design repo was used for creating this monochrome logo.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 7, 2021
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DenverCoder1 for your contribution! The icon is looking good overall 💯

There is a little difference in the horizontal bar that might be due to the optimization process (you can try with a precision of 4 if needed):
image

Can you give this one another try?

@DenverCoder1
Copy link
Contributor Author

@service-paradis I have tried with precision set to 4. It looks accurate to me, hopefully there are no issues.

Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DenverCoder1, it is perfect now 💯
If you can bring your PR up-to-date with develop, I will be able to merge this one :)

@DenverCoder1
Copy link
Contributor Author

@service-paradis Thanks, it should be up to date now

@service-paradis service-paradis merged commit 91eddf0 into simple-icons:develop Jun 15, 2021
ericcornelissen added a commit that referenced this pull request Jun 20, 2021
# New Icons

- Binance (#5906)
- ByteDance (#5909)
- Cloud Foundry (#5841)
- dbt (#5492)
- Foursquare City Guide (#5989)
- Icons8 (#5924)
- Polywork (#5806)
- Portainer (#5868)
- Pytest (#5871)
- Railway (#5818)
- Wallabag (#5864)
- Zig (#5572)

# Updated Icons

- Battle.net (#5986)
- Beatport (#5985)
- Foursquare (#5989)
- Grubhub (#5168)

---

:warning: The old `Foursquare` SVG can now be found as `Foursquare City Guide`, see #5989 for more info.
dirien pushed a commit to dirien/simple-icons that referenced this pull request Jul 20, 2021
* Create pytest.svg

* Version 2

* Update simple-icons.json

* Remove "icon" from title

* Update pytest.svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest
2 participants