Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Foursquare & Add Foursquare City Guide #5989

Merged

Conversation

service-paradis
Copy link
Member

image

Issue: Close #5977
Alexa rank: ~3.5k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jun 17, 2021
@service-paradis
Copy link
Member Author

service-paradis commented Jun 17, 2021

After looking more into this one, I think the old logo is now for their product called Foursquare City Guide
image

So instead of updating the current brand, I'm wondering if we should rename the current brand to "Foursquare City Guide" and add another one for Foursquare with the logo in this PR...

If so, it would be a breaking change... What other @simple-icons/maintainers think of this one?

@service-paradis service-paradis added the in discussion There is an ongoing discussion that should be finished before we can continue label Jun 17, 2021
@ericcornelissen
Copy link
Contributor

So instead of updating the current brand, I'm wondering if we should rename the current brand to "Foursquare City Guide" and add another one for Foursquare with the logo in this PR...

If so, it would be a breaking change... What other @simple-icons/maintainers think of this one?

I'd say we can just update the logo for Foursquare and add a new one for Foursquare City Guide. If I'm understanding this correctly that would have correct end result and require no breaking changes.

@service-paradis
Copy link
Member Author

It is not a hard breaking change, for sure, but I assume most people using the current icon want to display the icon for "Foursquare City Guide". So the icon for these people will be wrong and they will need to update the slug if they want the original icon.

@ericcornelissen
Copy link
Contributor

It is not a hard breaking change, for sure, but I assume most people using the current icon want to display the icon for "Foursquare City Guide". So the icon for these people will be wrong and they will need to update the slug if they want the original icon.

Hmm, I guess that's a fair point. Technically they're using the wrong icon if they're using the "Foursquare" icon for "Foursquare City Guide", but the confusion is understandable and not entirely their fault.

On the other hand, people that are actually using it for Foursquare, correctly, expect to have the correct logo. So from that point of view it should be updated.

I'm personally of the opinion that the people using the icon for the "wrong" brand should have to deal with this rather than the people using the icon for the "right" brand, but I would love to hear some more opinions.

If we do decide to go ahead and merge this in as "Foursquare" I do think we should try to release "Foursquare City Guide" in the same release and add a note about it to the release notes.

@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Jun 18, 2021

Interesting conundrum; I agree with both arguments being out forth and for me it would be a breaking change. Ultimately, though, I think I land on @ericcornelissen's side of things: Foursquare is Foursquare, that they've separated the branding of the company from the City Guide is on them not us and we should update our Foursquare icon now for those using it to represent the company and, with it, add back in the old icon as Foursquare City Guide. To me, it would be similar to when they separated check-ins out into Swarm and rebranded Foursquare - at the time, most people would have been using the Foursquare icon to link people to checking in.

That said the icon and colour look perfect to me 👍🏻 I think, though, we should use the brand page for the source as well as the guidelines - there's an SVG in the footer of that page. And, to ensure it goes out in the same release, let's add the old icon back in in this PR as Foursquare City Guide. Once that's done, and assuming none of the other @simple-icons/maintainers disagree strongly enough about this being a breaking change, then this can be merged straight in.

@service-paradis
Copy link
Member Author

Thank you both for your feedback.
So I just pushed the mentionned changes:

  • Uses the brand page as source
  • Add Foursquare City Guide entry with the previous Foursquare icon

It gives the following icons:
image
image

@PeterShaggyNoble PeterShaggyNoble removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jun 18, 2021
@PeterShaggyNoble PeterShaggyNoble changed the title Update Foursquare icon Update Foursquare & Add Foursquare City Guide Jun 18, 2021
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @service-paradis. Given the 👍🏻s on Eric's & my comments, it looks like we're in agreement in making this change now.

@PeterShaggyNoble PeterShaggyNoble merged commit 793d2b2 into simple-icons:develop Jun 18, 2021
@service-paradis service-paradis deleted the update-foursquare branch June 18, 2021 14:50
@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Jun 19, 2021
ericcornelissen added a commit that referenced this pull request Jun 20, 2021
# New Icons

- Binance (#5906)
- ByteDance (#5909)
- Cloud Foundry (#5841)
- dbt (#5492)
- Foursquare City Guide (#5989)
- Icons8 (#5924)
- Polywork (#5806)
- Portainer (#5868)
- Pytest (#5871)
- Railway (#5818)
- Wallabag (#5864)
- Zig (#5572)

# Updated Icons

- Battle.net (#5986)
- Beatport (#5985)
- Foursquare (#5989)
- Grubhub (#5168)

---

:warning: The old `Foursquare` SVG can now be found as `Foursquare City Guide`, see #5989 for more info.
dirien pushed a commit to dirien/simple-icons that referenced this pull request Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Foursquare
3 participants