-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Foursquare & Add Foursquare City Guide #5989
Update Foursquare & Add Foursquare City Guide #5989
Conversation
After looking more into this one, I think the old logo is now for their product called Foursquare City Guide So instead of updating the current brand, I'm wondering if we should rename the current brand to "Foursquare City Guide" and add another one for Foursquare with the logo in this PR... If so, it would be a breaking change... What other @simple-icons/maintainers think of this one? |
I'd say we can just update the logo for Foursquare and add a new one for Foursquare City Guide. If I'm understanding this correctly that would have correct end result and require no breaking changes. |
It is not a hard breaking change, for sure, but I assume most people using the current icon want to display the icon for "Foursquare City Guide". So the icon for these people will be wrong and they will need to update the slug if they want the original icon. |
Hmm, I guess that's a fair point. Technically they're using the wrong icon if they're using the "Foursquare" icon for "Foursquare City Guide", but the confusion is understandable and not entirely their fault. On the other hand, people that are actually using it for Foursquare, correctly, expect to have the correct logo. So from that point of view it should be updated. I'm personally of the opinion that the people using the icon for the "wrong" brand should have to deal with this rather than the people using the icon for the "right" brand, but I would love to hear some more opinions. If we do decide to go ahead and merge this in as "Foursquare" I do think we should try to release "Foursquare City Guide" in the same release and add a note about it to the release notes. |
Interesting conundrum; I agree with both arguments being out forth and for me it would be a breaking change. Ultimately, though, I think I land on @ericcornelissen's side of things: Foursquare is Foursquare, that they've separated the branding of the company from the City Guide is on them not us and we should update our Foursquare icon now for those using it to represent the company and, with it, add back in the old icon as Foursquare City Guide. To me, it would be similar to when they separated check-ins out into Swarm and rebranded Foursquare - at the time, most people would have been using the Foursquare icon to link people to checking in. That said the icon and colour look perfect to me 👍🏻 I think, though, we should use the brand page for the |
1927ee5
to
50f8823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @service-paradis. Given the 👍🏻s on Eric's & my comments, it looks like we're in agreement in making this change now.
# New Icons - Binance (#5906) - ByteDance (#5909) - Cloud Foundry (#5841) - dbt (#5492) - Foursquare City Guide (#5989) - Icons8 (#5924) - Polywork (#5806) - Portainer (#5868) - Pytest (#5871) - Railway (#5818) - Wallabag (#5864) - Zig (#5572) # Updated Icons - Battle.net (#5986) - Beatport (#5985) - Foursquare (#5989) - Grubhub (#5168) --- :warning: The old `Foursquare` SVG can now be found as `Foursquare City Guide`, see #5989 for more info.
Issue: Close #5977
Alexa rank: ~3.5k
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description