Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data for JPEG logo #6320

Merged
merged 7 commits into from Aug 25, 2021

Conversation

gizmecano
Copy link
Contributor

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

As the source of the file is not set explicitly on the contact page, the link seems to be updatable by pointing to the mentioned downloadable file rather than the page in question.

In addition, this downloadable file contains a document entitled "license_agreement.pdf" which specifies the license in its Terms and conditions section, alinea b:

b. The owner grants perpetual, non-transferrable, non-exclusive usage of the JPEG logo to any person and/or legal entity under the “Creative Commons Attribution-NoDerivatives 4.0 International License”.

However, since this file is included in a downloadable file, it seems inappropriate to add a direct link to the license.

Copy link
Contributor

@jorgeamadosoria jorgeamadosoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source change is too specific. This is vulnerable to changes on JPEG side that would render the source obsolete.
The addition of the license is fine, but I would revert the source to the original value

@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Aug 24, 2021

@gizmecano Can you please update the branch? When the branch is updated to the base branch we can merge this PR 👍

@ericcornelissen ericcornelissen merged commit ff44797 into simple-icons:develop Aug 25, 2021
ericcornelissen added a commit that referenced this pull request Aug 29, 2021
# New Icons

- E.Leclerc (#6387)
- Hetzner (#6146)
- Joplin (#6341)
- KinoPoisk (#5660)
- MAMP (#6292)
- OpenMined (#6366)

# Updated Icons

- freeCodeCamp (#6322)
- JPEG (#6320)
- Matternet (#6222)
- OpenAPI Initiative (#6223)
- Renren (#6217)
- Sat.1 (#6219)
- Semaphore CI (#6230)
- Server Fault (#6227)
- TuneIn (#6220)
@gizmecano gizmecano deleted the input/data/jpeg branch August 29, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants