New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data for JPEG logo #6320
Update data for JPEG logo #6320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source change is too specific. This is vulnerable to changes on JPEG side that would render the source obsolete.
The addition of the license is fine, but I would revert the source to the original value
@gizmecano Can you please update the branch? When the branch is updated to the base branch we can merge this PR 👍 |
# New Icons - E.Leclerc (#6387) - Hetzner (#6146) - Joplin (#6341) - KinoPoisk (#5660) - MAMP (#6292) - OpenMined (#6366) # Updated Icons - freeCodeCamp (#6322) - JPEG (#6320) - Matternet (#6222) - OpenAPI Initiative (#6223) - Renren (#6217) - Sat.1 (#6219) - Semaphore CI (#6230) - Server Fault (#6227) - TuneIn (#6220)
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
As the source of the file is not set explicitly on the contact page, the link seems to be updatable by pointing to the mentioned downloadable file rather than the page in question.
In addition, this downloadable file contains a document entitled "license_agreement.pdf" which specifies the license in its Terms and conditions section, alinea b:
However, since this file is included in a downloadable file, it seems inappropriate to add a direct link to the license.