New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E.Leclerc icon #6387
Add E.Leclerc icon #6387
Conversation
Hi @service-paradis and @ericcornelissen, any idea how to handle a dot in the brand name? |
I think the idea is to substitute the . for "dot". |
05bd0a6
to
650c73f
Compare
@jorgeamadosoria, thanks a lot for the help. |
that's what we are here for. One for me, one for you :) |
This path is precision 4, and I find it coincides with your source rather well.
|
Good answer by @jorgeamadosoria! There is also another thing we can take into account. Do we pronounce the "dot" when we talk about the brand? For example, we say "dot net" when talking about ".Net", but not "del dot icio dot us" when talking about "del.icio.us". For the latter, we use a "slug" so we name the file @dirien Since I'm not familiar with the brands, I will let you judge if you want to use a slug or not for this one. Better naming it as expected now since it will be a breaking change to rename it at a later time. |
Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
@jorgeamadosoria, thanks for the new svg. |
you are correct, I forgot about the pronunciation point. |
I will check the new path against the source later today. Meanwhile, what's the answer to @service-paradis question regarding pronunciation? |
@service-paradis and @jorgeamadosoria. I know that in France you only say First time of my life i had to google for an advertisment to confirm it. https://youtu.be/uf-J2THUG1k?t=28 So i would probably ask for a |
Indeed, as far as I can remember I've always heard it said simply "Leclerc" by French speaking people: the "E" in formal wording stands for the first name of the founder "Édouard". |
I think using a slug is appropriate for this one. You might also add an |
I've checked the second SVG @dirien, and it's a 100% match from my side. LGTM! |
# New Icons - E.Leclerc (#6387) - Hetzner (#6146) - Joplin (#6341) - KinoPoisk (#5660) - MAMP (#6292) - OpenMined (#6366) # Updated Icons - freeCodeCamp (#6322) - JPEG (#6320) - Matternet (#6222) - OpenAPI Initiative (#6223) - Renren (#6217) - Sat.1 (#6219) - Semaphore CI (#6230) - Server Fault (#6227) - TuneIn (#6220)
Signed-off-by: Engin Diri engin.diri@mail.schwarz
Issue: # #6386
Alexa rank: 21,639
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
From their website and https://www.e.leclerc/assets/images/sue-logo.svg as base.
Color: #0066CC