Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E.Leclerc icon #6387

Merged
merged 1 commit into from Aug 28, 2021
Merged

Add E.Leclerc icon #6387

merged 1 commit into from Aug 28, 2021

Conversation

dirien
Copy link
Member

@dirien dirien commented Aug 25, 2021

Signed-off-by: Engin Diri engin.diri@mail.schwarz

image

Issue: # #6386
Alexa rank: 21,639

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

From their website and https://www.e.leclerc/assets/images/sue-logo.svg as base.

Color: #0066CC

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 25, 2021
@dirien
Copy link
Member Author

dirien commented Aug 25, 2021

Hi @service-paradis and @ericcornelissen,

any idea how to handle a dot in the brand name?

@dirien dirien linked an issue Aug 25, 2021 that may be closed by this pull request
@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Aug 25, 2021

Hi @service-paradis and @ericcornelissen,

any idea how to handle a dot in the brand name?

I think the idea is to substitute the . for "dot".
In this case, the name of the SVG (or slug) would be "edotleclerc".
I think the relevant guideline is this one: https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#6-name-the-icon

@dirien dirien force-pushed the e-leclerc branch 2 times, most recently from 05bd0a6 to 650c73f Compare August 25, 2021 15:05
@dirien
Copy link
Member Author

dirien commented Aug 25, 2021

@jorgeamadosoria, thanks a lot for the help.

@jorgeamadosoria
Copy link
Contributor

@jorgeamadosoria, thanks a lot for the help.

that's what we are here for. One for me, one for you :)

@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Aug 25, 2021

Reviewing the icon against your source (after taking out the letters and uniting the paths) I see slight divergences:
image

In my previous experience, this is due to precision issues in svgo. It tends to happen more in logos that require preparation (like taking out letters or moving things around) and that have curves.

@jorgeamadosoria
Copy link
Contributor

This path is precision 4, and I find it coincides with your source rather well.
Can you please try it on your side, see if it works?

M12.0006 0C5.4304 0 .104 5.373.104 12.0006.1041 18.628 5.4304 24 12.0006 24c6.57 0 11.8953-5.372 11.8953-11.9994C23.8959 5.373 18.5705 0 12.0006 0zm0 2.491c5.2064 0 9.4266 4.2576 9.4266 9.5096 0 5.2518-4.2202 9.5085-9.4266 9.5085-5.2065 0-9.4278-4.2567-9.4278-9.5085 0-5.252 4.2213-9.5097 9.4278-9.5097zm1.1477 1.9912c-1.4425 0-2.7735.4696-3.8562 1.266h3.1929V8.982c-.556.0284-1.0156.4782-1.0156 1.0436v5.4499h.9442c1.2058 0 1.5093-1.4532 1.5093-1.4532h2.836l.001 2.5939c1.7738-1.1835 2.9437-3.215 2.9437-5.5212 0-3.6525-2.9346-6.6128-6.5554-6.6128zM6.49 6.7322v1.6204c.5462.1418 1.018.6113 1.018 1.3817v5.4592c0 .6162-.4365 1.1693-1.018 1.315v2.0943h9.3003V15.004l-1.2344.007c-.348.8466-1.1771 1.4415-2.1422 1.4415h-1.913V9.691c0-.6981.4543-1.1824 1.0156-1.335V6.7322z

@service-paradis
Copy link
Member

service-paradis commented Aug 25, 2021

Hi @service-paradis and @ericcornelissen,
any idea how to handle a dot in the brand name?

I think the idea is to substitute the . for "dot".
In this case, the name of the SVG (or slug) would be "edotleclerc".
I think the relevant guideline is this one: https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#6-name-the-icon

Good answer by @jorgeamadosoria! There is also another thing we can take into account. Do we pronounce the "dot" when we talk about the brand? For example, we say "dot net" when talking about ".Net", but not "del dot icio dot us" when talking about "del.icio.us". For the latter, we use a "slug" so we name the file delicious.svg instead of deldoticiodotus.svg.

@dirien Since I'm not familiar with the brands, I will let you judge if you want to use a slug or not for this one. Better naming it as expected now since it will be a breaking change to rename it at a later time.

Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
@dirien
Copy link
Member Author

dirien commented Aug 25, 2021

@jorgeamadosoria, thanks for the new svg.

image

@jorgeamadosoria
Copy link
Contributor

Good answer by @jorgeamadosoria! There is also another thing we can take into account. Do we pronounce the "dot" when we talk about the brand? For example, we say "dot net" when talking about ".Net", but not "del dot icio dot us" when talking about "del.icio.us". For the latter, we use a "slug" so we name the file delicious.svg instead of deldoticiodotus.svg.

@dirien Since I'm not familiar with the brands, I will let you judge if you want to use a slug or not for this one. Better naming it as expected now since it will be a breaking change to rename it at a later time.

you are correct, I forgot about the pronunciation point.

@jorgeamadosoria
Copy link
Contributor

@jorgeamadosoria, thanks for the new svg.

image

I will check the new path against the source later today. Meanwhile, what's the answer to @service-paradis question regarding pronunciation?

@dirien
Copy link
Member Author

dirien commented Aug 25, 2021

@service-paradis and @jorgeamadosoria. I know that in France you only say Leclerc.

First time of my life i had to google for an advertisment to confirm it.

https://youtu.be/uf-J2THUG1k?t=28

So i would probably ask for a slug

@gizmecano
Copy link
Contributor

I know that in France you only say Leclerc.

Indeed, as far as I can remember I've always heard it said simply "Leclerc" by French speaking people: the "E" in formal wording stands for the first name of the founder "Édouard".

@service-paradis
Copy link
Member

@service-paradis and @jorgeamadosoria. I know that in France you only say Leclerc.

First time of my life i had to google for an advertisment to confirm it.

https://youtu.be/uf-J2THUG1k?t=28

So i would probably ask for a slug

I think using a slug is appropriate for this one. You might also add an aka property with "Leclerc" only as value if the brand is often called like that only.

@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Aug 28, 2021

@jorgeamadosoria, thanks for the new svg.
image

I've checked the second SVG @dirien, and it's a 100% match from my side. LGTM!

@jorgeamadosoria jorgeamadosoria merged commit c03ecb5 into simple-icons:develop Aug 28, 2021
ericcornelissen added a commit that referenced this pull request Aug 29, 2021
# New Icons

- E.Leclerc (#6387)
- Hetzner (#6146)
- Joplin (#6341)
- KinoPoisk (#5660)
- MAMP (#6292)
- OpenMined (#6366)

# Updated Icons

- freeCodeCamp (#6322)
- JPEG (#6320)
- Matternet (#6222)
- OpenAPI Initiative (#6223)
- Renren (#6217)
- Sat.1 (#6219)
- Semaphore CI (#6230)
- Server Fault (#6227)
- TuneIn (#6220)
@dirien dirien deleted the e-leclerc branch August 29, 2021 13:51
@adamrusted adamrusted mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Icon: E.Leclerc
4 participants