Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data for freecodecamp logo #6322

Merged

Conversation

gizmecano
Copy link
Contributor

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

With the introduction of optional data, it may seem more appropriate to revamp data for the freecodecamp logo (by explicitly splitting source file and guidelines reference).

@jorgeamadosoria
Copy link
Contributor

@gizmecano We try not to be overly specific with the urls for sources, just in case they change and the source gets invalidated.
In this case, it's fine to put the same url in both guidelines and source, since the download for the source is within the guideline pages (this is not always the case).

(if the SVG file was sourced from the guidelines, the URL should be duplicated here)
@jorgeamadosoria jorgeamadosoria merged commit d02fbaf into simple-icons:develop Aug 23, 2021
jorgeamadosoria added a commit that referenced this pull request Aug 24, 2021
* Update data for freecodecamp logo

* Use single URL for `source` and `guidelines`

(if the SVG file was sourced from the guidelines, the URL should be duplicated here)

Co-authored-by: Jorge Amado Soria Ramirez <darksoul.uci@gmail.com>
ericcornelissen added a commit that referenced this pull request Aug 29, 2021
# New Icons

- E.Leclerc (#6387)
- Hetzner (#6146)
- Joplin (#6341)
- KinoPoisk (#5660)
- MAMP (#6292)
- OpenMined (#6366)

# Updated Icons

- freeCodeCamp (#6322)
- JPEG (#6320)
- Matternet (#6222)
- OpenAPI Initiative (#6223)
- Renren (#6217)
- Sat.1 (#6219)
- Semaphore CI (#6230)
- Server Fault (#6227)
- TuneIn (#6220)
@gizmecano gizmecano deleted the input/data/freecodecamp branch August 29, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants