Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rossmann icon #6459

Merged
merged 2 commits into from Jan 28, 2022
Merged

Add Rossmann icon #6459

merged 2 commits into from Jan 28, 2022

Conversation

dirien
Copy link
Member

@dirien dirien commented Sep 2, 2021 •
edited

Signed-off-by: Engin Diri engin.diri@mail.schwarz

image

Issue: #6458
Alexa rank: 33,902

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon -> https://www.rossmann.de/unternehmen/resources/templating-kit/themes/rsmn-corp/5.97.0-2021.08.16.05.53/images/layout/logo.svg

@dirien dirien linked an issue Sep 2, 2021 that may be closed by this pull request
Request: Rossmann #6458
Closed
@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 2, 2021
@dirien
Copy link
Member Author

dirien commented Dec 22, 2021

Create a comparison
image

sachinraja
sachinraja suggested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@sachinraja sachinraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@dirien
Copy link
Member Author

dirien commented Jan 15, 2022

Hi @sachinraja, thanks for pointing out. Fixed it :)

@dirien
Copy link
Member Author

dirien commented Jan 23, 2022

@sachinraja: I used this file -> https://www.rossmann.de/unternehmen/resources/templating-kit/themes/rsmn-corp/5.97.0-2021.08.16.05.53/images/layout/logo.svg

sachinraja
sachinraja suggested changes Jan 25, 2022
View reviewed changes
_data/simple-icons.json Outdated
"title": "Rossmann",
"hex": "C3002D",
"source": "https://www.rossmann.de",
"guidelines": "https://www.rossmann.de/unternehmen/presse/media-downloads/logos.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon is a perfect match, but https://www.rossmann.de/unternehmen/presse/media-downloads/logos.html does not seem to exist. It just redirects to https://unternehmen.rossmann.de/presse/mediathek.html which is not a guidelines page.

@dirien
Copy link
Member Author

dirien commented Jan 26, 2022

@sachinraja removed the guideline tags. Looks like they changed their HP

@sachinraja sachinraja merged commit 1974c8f into simple-icons:develop Jan 28, 2022
@dirien dirien deleted the rossmann branch January 28, 2022 22:34
@github-actions github-actions bot mentioned this pull request Jan 30, 2022
Merged
mondeja added a commit that referenced this pull request Jan 30, 2022
@mondeja
Release 11 new icons (v6.8.0)
36423c8 
# New Icons

- Conan (#7090)
- Exoscale (#7044)
- Kuma (#7095)
- Müller (#6461)
- Monoprix (#6411)
- NetBSD (#7064)
- OpenSea (#7053)
- Otto (#6471)
- Rossmann (#6459)
- Velog (#7025)
- VTEX (#6989)
@adamrusted adamrusted mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinraja sachinraja sachinraja approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Rossmann
2 participants
@dirien @sachinraja