Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Müller icon #6461

Merged
merged 2 commits into from Jan 25, 2022
Merged

Add Müller icon #6461

merged 2 commits into from Jan 25, 2022

Conversation

dirien
Copy link
Member

@dirien dirien commented Sep 2, 2021 •
edited

Signed-off-by: Engin Diri engin.diri@mail.schwarz

image

Issue: #6460
Alexa rank: 65,838

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

icon -> https://www.mueller.de/7aaea20bf455fcb4119f987a33c3860fb6bd5dc6/assets/base/images/logotype.svg

@dirien dirien linked an issue Sep 2, 2021 that may be closed by this pull request
Request: Müller #6460
Closed
@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 2, 2021
@dirien dirien force-pushed the mueller branch 2 times, most recently from 33e6f4f to 3adfe78 Compare December 22, 2021 14:07
@dirien
Copy link
Member Author

dirien commented Dec 22, 2021

Add a comparison

image

@dirien dirien force-pushed the mueller branch 2 times, most recently from 070a888 to 6aafc2b Compare December 22, 2021 14:18
sachinraja
sachinraja suggested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@sachinraja sachinraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

differences along the edges
image

Add Müller icon
b8e01f8 
Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
@dirien
Copy link
Member Author

dirien commented Jan 15, 2022

Hi @sachinraja,

i checked the Icon, but I could not see this strong difference like you have on your screenshot

image

@sachinraja
Copy link
Contributor

Can you send the exact link to your source?

@sachinraja
Copy link
Contributor

Can you send the exact link to your source?

bumping this @dirien

@dirien
Copy link
Member Author

dirien commented Jan 23, 2022

@sachinraja it's in the issue and in the description of the PR

sachinraja
sachinraja approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@sachinraja sachinraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, another perfect match!

@sachinraja sachinraja merged commit 55b18a6 into simple-icons:develop Jan 25, 2022
@dirien dirien deleted the mueller branch January 28, 2022 22:34
@github-actions github-actions bot mentioned this pull request Jan 30, 2022
Merged
mondeja added a commit that referenced this pull request Jan 30, 2022
@mondeja
Release 11 new icons (v6.8.0)
36423c8 
# New Icons

- Conan (#7090)
- Exoscale (#7044)
- Kuma (#7095)
- M&#252;ller (#6461)
- Monoprix (#6411)
- NetBSD (#7064)
- OpenSea (#7053)
- Otto (#6471)
- Rossmann (#6459)
- Velog (#7025)
- VTEX (#6989)
@adamrusted adamrusted mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinraja sachinraja sachinraja approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Müller
2 participants
@dirien @sachinraja