Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Modin icon #7836

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Add Modin icon #7836

merged 1 commit into from
Mar 5, 2023

Conversation

elliotwutingfeng
Copy link
Contributor

@elliotwutingfeng elliotwutingfeng commented Sep 21, 2022 •
edited
Loading

image

Issue: closes #7627

GitHub Stars: 7.6k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

nil

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 21, 2022
@LitoMore
Copy link
Member

CleanShot 2022-09-21 at 11 42 23@2x

@elliotwutingfeng I see some difference. Could you give a check?

@elliotwutingfeng
Copy link
Contributor Author

Oops I missed those! I can't find a way to extrude those 6 holes using Path -> Exclusion, they are causing the X-coords and the Width of the rest of the svg to shift.

@LitoMore
Copy link
Member

They are already there. You don't need any calculation on it. Are you using this resource? If not please use this one instead.

@elliotwutingfeng
Copy link
Contributor Author

elliotwutingfeng commented Sep 21, 2022 •
edited
Loading

Yes, now svgo keeps increasing the width of the image.

Edit: Try this one.

@LitoMore
Copy link
Member

CleanShot 2022-09-21 at 18 42 56@2x

@elliotwutingfeng I see some difference. Let's increase its precision to 4.

dirien
dirien requested changes Nov 24, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @LitoMore wrote, I can confirm.

@elliotwutingfeng elliotwutingfeng mentioned this pull request Mar 1, 2023
Closed
3 tasks
dirien
dirien approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elliotwutingfeng,

Thanks for your contribution to simple-icons!

It's a perfect fit:
image

@dirien dirien merged commit c1646ae into simple-icons:develop Mar 5, 2023
@elliotwutingfeng elliotwutingfeng deleted the modin branch March 5, 2023 22:37
@github-actions github-actions bot mentioned this pull request Mar 12, 2023
Merged
mondeja added a commit that referenced this pull request Mar 15, 2023
@mondeja
Release 3 new icons (v8.7.0)
aa70b1e 
# New Icons

- FontForge (#8379)
- Modin (#7836)
- Redox (#8394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modin
3 participants
@elliotwutingfeng @LitoMore @dirien