Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Babylon.js icon #8737

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Add Babylon.js icon #8737

merged 7 commits into from
Jun 20, 2023

Conversation

timondev
Copy link
Contributor

@timondev timondev commented Jun 6, 2023 •
edited by service-paradis
Loading

Issue: closes #8736 close #7148

Similarweb rank:

The Similarweb rank is 140,065. See https://www.similarweb.com/website/babylonjs.com/#overview
The Github repo has 20.8k stars.

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 6, 2023
@RiteshK-611 RiteshK-611 mentioned this pull request Jun 16, 2023
Closed
LitoMore
LitoMore approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@timondev Perfect fit. Thank you for contributing!

@LitoMore LitoMore merged commit 6008c98 into simple-icons:develop Jun 20, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2023
Merged
mondeja added a commit that referenced this pull request Jun 25, 2023
@mondeja
Release 21 new icons (v9.3.0)
7f1f860 
# New Icons

- Acura (#8864)
- Amazon Redshift (#8725)
- Appsmith (#7915)
- Babylon.js (#8737)
- Cadillac (#8865)
- DOI (#8525)
- Eclipse Adoptium (#8791)
- Fi (#8380)
- Immich (#8388)
- Kinsta (#8845)
- Logseq (#8311)
- mail.com (#8843)
- MapLibre (#7187)
- MG (#8866)
- Monkeytype (#8846)
- Nginx Proxy Manager (#8769)
- NXP (#8748)
- Prefect (#8772)
- Proton (#7792)
- Skyrock (#8298)
- Trivy (#8855)
@adamrusted
Copy link
Member

@LitoMore - as per their licensing, we should not have accepted a single-color variant of the logo that wasn't officially supplied on their repo. I've mentioned it on #6317 - but we may need to look at removal, or requesting that they add our SVG as an appropriate option.

@LitoMore
Copy link
Member

LitoMore commented Jul 9, 2023

@adamrusted Thanks. I will send a request to https://github.com/BabylonJS/Brand-Toolkit.

@PeterShaggyNoble
Copy link
Member

@LitoMore, did you ever hear back from them? If not then we should queue this up for removal in v11 until we do.

@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Babylon.js Request: babylon.js
4 participants
@timondev @adamrusted @LitoMore @PeterShaggyNoble