Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proton drive #8902

Merged
merged 4 commits into from Jul 9, 2023
Merged

Update proton drive #8902

merged 4 commits into from Jul 9, 2023

Conversation

PratyushJayachandran
Copy link
Member

protondrive

Issue: closes #7451

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from brand website https://proton.me/media/kit
Color: #EB508D taken from brand website color palette
image

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jun 29, 2023
adamrusted
adamrusted approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @PratyushJayachandran 🎉

@adamrusted adamrusted merged commit 871234e into simple-icons:develop Jul 9, 2023
3 checks passed
@PratyushJayachandran PratyushJayachandran deleted the Update-Proton-Drive branch July 9, 2023 09:23
@PratyushJayachandran
Copy link
Member Author

PratyushJayachandran commented Jul 9, 2023 •
edited

LGTM! Thanks @PratyushJayachandran 🎉

You are welcome 😊

The other proton icons were updated recently with the color as purple. Should I change them to respective colors as mentioned in the media kit. Can I make a single PR for that?

@adamrusted
Copy link
Member

The other proton icons were updated recently with the color as purple. Should I change them to respective colors as mentioned in the media kit. Can I make a single PR for that?

If you could, that'd be great! A single PR to update the 'data' of multiple (related) icons is absolutely fine!

@adamrusted adamrusted mentioned this pull request Jul 9, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jul 16, 2023
Merged
mondeja added a commit that referenced this pull request Jul 16, 2023
@mondeja
Release 4 new icons and 9 updated icons (v9.6.0)
bb885cf 
# New Icons

- Libera.Chat (#6009)
- Mautic (#6627)
- Pterodactyl (#8860)
- Sphere Online Judge (#6497)

# Updated Icons

- Broadcom (#8957)
- CurseForge (#8773)
- Dacia (#6017)
- Dask (#8986)
- Fujifilm (#8939)
- Proton Drive (#8902)
- ProtonVPN (#8973)
- Scribd (#7802)
- Ubiquiti (#8927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proton update
2 participants
@PratyushJayachandran @adamrusted