Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fujifilm #8939

Merged
merged 6 commits into from Jul 9, 2023
Merged

Update fujifilm #8939

merged 6 commits into from Jul 9, 2023

Conversation

PratyushJayachandran
Copy link
Member

@PratyushJayachandran PratyushJayachandran commented Jul 4, 2023 •
edited

fujifilm

Issue: closes #

Similarweb rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from website header https://www.fujifilm.com/us/themes/custom/fujifilm_com_g2/common/img/fujifilm_corporate_logo.svg
Color: #FB0020 Taken from the same SVG. Although it can also be green based on Fujifilm packaging since a long time. https://www.fujifilm.com/us/en/social-media/apps

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jul 4, 2023
@PratyushJayachandran
Copy link
Member Author

The icon is already in the project but I am not sure if we can add their logo after reading the terms
https://www.fujifilm.com/us/en/terms

adamrusted
adamrusted requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon itself looks perfect, just one nit-pick regarding the source. Otherwise, great job @PratyushJayachandran!

_data/simple-icons.json Outdated Show resolved Hide resolved
@PratyushJayachandran
Copy link
Member Author

Icon itself looks perfect, just one nit-pick regarding the source. Otherwise, great job @PratyushJayachandran!

I usually only add the website but I saw other icons with absolute address so I thought I'll do the same🙈

Will stick to just the website unless they have a branding page.

@PratyushJayachandran
update source to website
f887654 
Co-authored-by: Adam Rusted <hello@adamrusted.me>
adamrusted
adamrusted approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @PratyushJayachandran 🎉

@adamrusted adamrusted merged commit 5f2eb37 into simple-icons:develop Jul 9, 2023
4 checks passed
@PratyushJayachandran PratyushJayachandran deleted the Update-Fujifilm branch July 9, 2023 09:01
@github-actions github-actions bot mentioned this pull request Jul 16, 2023
Merged
mondeja added a commit that referenced this pull request Jul 16, 2023
@mondeja
Release 4 new icons and 9 updated icons (v9.6.0)
bb885cf 
# New Icons

- Libera.Chat (#6009)
- Mautic (#6627)
- Pterodactyl (#8860)
- Sphere Online Judge (#6497)

# Updated Icons

- Broadcom (#8957)
- CurseForge (#8773)
- Dacia (#6017)
- Dask (#8986)
- Fujifilm (#8939)
- Proton Drive (#8902)
- ProtonVPN (#8973)
- Scribd (#7802)
- Ubiquiti (#8927)
@PratyushJayachandran PratyushJayachandran mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PratyushJayachandran @adamrusted