Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ubiquiti Icon #8927

Merged
merged 11 commits into from Jul 10, 2023
Merged

Update Ubiquiti Icon #8927

merged 11 commits into from Jul 10, 2023

Conversation

RiteshK-611
Copy link
Contributor

@RiteshK-611 RiteshK-611 commented Jul 3, 2023 •
edited

Issue: closes #5667

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

This change resolves issue #5667 by updating Ubiquiti logo in ubiquiti.svg file

Preview

ubiquiti

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jul 3, 2023
service-paradis
service-paradis requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RiteshK-611 for your contribution!

I'm seeing some differences that might be due to SVGO precision. Which logo did you use? I compared it using the one found in their Website homepage header.

Also, we'll need to update source in simple-icons.json since https://www.ui.com/marketing/#logos does not exists anymore.

@RiteshK-611
Copy link
Contributor Author

Thanks @service-paradis for pointing out my mistake. I updated the source link 👍

adamrusted
adamrusted reviewed Jul 7, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@RiteshK-611
Update source link
6e05c73 
Co-authored-by: Adam Rusted <hello@adamrusted.me>
adamrusted
adamrusted requested changes Jul 8, 2023
View reviewed changes
icons/ubiquiti.svg Outdated Show resolved Hide resolved
service-paradis
service-paradis approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, Thank you @RiteshK-611 💯

@service-paradis service-paradis merged commit 09f2c30 into simple-icons:develop Jul 10, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2023
Merged
mondeja added a commit that referenced this pull request Jul 16, 2023
@mondeja
Release 4 new icons and 9 updated icons (v9.6.0)
bb885cf 
# New Icons

- Libera.Chat (#6009)
- Mautic (#6627)
- Pterodactyl (#8860)
- Sphere Online Judge (#6497)

# Updated Icons

- Broadcom (#8957)
- CurseForge (#8773)
- Dacia (#6017)
- Dask (#8986)
- Fujifilm (#8939)
- Proton Drive (#8902)
- ProtonVPN (#8973)
- Scribd (#7802)
- Ubiquiti (#8927)
@adamrusted adamrusted removed their request for review November 15, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted requested changes

@service-paradis service-paradis service-paradis approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Ubiquiti
3 participants
@RiteshK-611 @adamrusted @service-paradis