Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ImprovMX Icon #9004

Merged
merged 2 commits into from Aug 10, 2023
Merged

Add ImprovMX Icon #9004

merged 2 commits into from Aug 10, 2023

Conversation

RiteshK-611
Copy link
Contributor

Issue: closes #9003

Similarweb rank:
Similarweb rank 506,280

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

This change resolves issue #9003 by adding ImprovMX logo in improvmx.svg file and by updating simple-icons.json file with icon's data

Preview

improvmx

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jul 13, 2023
@adamrusted
Copy link
Member

@RiteshK-611 - the SimilarWeb rank is just outside contribution criteria for this one, so we can't accept it on that. Is there another popularity metric (GitHub stars, etc) that we can use?

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jul 23, 2023
@mwskwong
Copy link

@RiteshK-611 - the SimilarWeb rank is just outside contribution criteria for this one, so we can't accept it on that. Is there another popularity metric (GitHub stars, etc) that we can use?

Does this help? (taken from my original issue)

A (fairly popular) email forwarding service that is featured by Vercel in a guide about sending emails with a purchased domain. Vercel also has set up DNS presents for ImproMX, suggesting its popularity among similar offerings.

@adamrusted
Copy link
Member

Looks like it just took some time for the Vercel post to hit the SimilarWeb ranking. Its now in scope.

@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 10, 2023
adamrusted
adamrusted approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @RiteshK-611 🎉

@adamrusted adamrusted merged commit ca71dcb into simple-icons:develop Aug 10, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 13, 2023
Merged
mondeja added a commit that referenced this pull request Aug 13, 2023
@mondeja
Release 5 new icons and 5 updated icons (v9.10.0)
c11c1d8 
# New Icons

- Clarivate (#9142)
- Distrokid (#9143)
- Google Bard (#9114)
- ImprovMX (#9004)
- InfoQ (#9148)

# Updated Icons

- Astro (#9201)
- SmugMug (#9237)
- Sourcegraph (#9174)
- Zcash (#9247)
- Zoom (#9211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request] ImprovMX
3 participants
@RiteshK-611 @adamrusted @mwskwong