Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sourcegraph #9174

Merged
merged 3 commits into from Aug 10, 2023
Merged

Update Sourcegraph #9174

merged 3 commits into from Aug 10, 2023

Conversation

PratyushJayachandran
Copy link
Member

sourcegraph

Issue: closes #6141

Similarweb rank: 127,369. See https://www.similarweb.com/website/sourcegraph.com

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from page 86 of Sourcegraph_Brand_Guidelines.pdf available here https://handbook.sourcegraph.com/departments/engineering/design/brand_guidelines/logo/
Color: As mentioned and used in the PDF, is supposed to be #000000 if not using the 3 colored version.

@PratyushJayachandran PratyushJayachandran changed the title Add sourcegraph Update sourcegraph Jul 31, 2023
@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jul 31, 2023
@PratyushJayachandran PratyushJayachandran changed the title Update sourcegraph Update Sourcegraph Jul 31, 2023
@PratyushJayachandran PratyushJayachandran mentioned this pull request Jul 31, 2023
Closed
@adamrusted
Copy link
Member

adamrusted commented Aug 10, 2023 •
edited

Unsure we can add this, see below. What do other @simple-icons/maintainers think?
image

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 10, 2023
@PratyushJayachandran
Copy link
Member Author

Unsure we can add this, see below. What do other @simple-icons/maintainers think? image

Ohh 😮 I missed that!

@service-paradis
Copy link
Member

Oh, we might need to remove this one in V10... We can update it for now since it is already part of the project though...

adamrusted
adamrusted approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version LGTM. Thanks @PratyushJayachandran!
Would you mind opening another PR for the removal of this icon in v10?

@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 10, 2023
@adamrusted adamrusted merged commit 88ae349 into simple-icons:develop Aug 10, 2023
3 checks passed
@PratyushJayachandran PratyushJayachandran deleted the Add-Sourcegraph branch August 11, 2023 06:30
@PratyushJayachandran PratyushJayachandran mentioned this pull request Aug 11, 2023
Merged
@PratyushJayachandran
Copy link
Member Author

This version LGTM. Thanks @PratyushJayachandran! Would you mind opening another PR for the removal of this icon in v10?

Done #9258

@github-actions github-actions bot mentioned this pull request Aug 13, 2023
Merged
mondeja added a commit that referenced this pull request Aug 13, 2023
@mondeja
Release 5 new icons and 5 updated icons (v9.10.0)
c11c1d8 
# New Icons

- Clarivate (#9142)
- Distrokid (#9143)
- Google Bard (#9114)
- ImprovMX (#9004)
- InfoQ (#9148)

# Updated Icons

- Astro (#9201)
- SmugMug (#9237)
- Sourcegraph (#9174)
- Zcash (#9247)
- Zoom (#9211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Sourcegraph icon
3 participants
@PratyushJayachandran @adamrusted @service-paradis