Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests and scripts #9237

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Refactor tests and scripts #9237

merged 9 commits into from
Aug 8, 2023

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Aug 8, 2023 •
edited
Loading

  • Don't allow single ' nor doble quotes " in URLs.
  • Explicitly import process module with node: protocol.
  • Refactor, normalize usage of APIs and remove duplicated code.
  • Updated SmugMug source as had a single quote and the current URL is returning 404 code.

@mondeja mondeja added meta Issues or pull requests regarding the project or repository itself icon data labels Aug 8, 2023
LitoMore
LitoMore reviewed Aug 8, 2023
View reviewed changes
sdk.mjs Outdated Show resolved Hide resolved
sdk.mjs Outdated Show resolved Hide resolved
scripts/release/update-cdn-urls.js Outdated Show resolved Hide resolved
scripts/release/update-svgs-count.js Outdated Show resolved Hide resolved
scripts/release/update-sdk-ts-defs.js Outdated Show resolved Hide resolved
mondeja and others added 2 commits August 8, 2023 06:26
@mondeja @LitoMore
Apply suggestions from code review
d6e72d0 
Co-authored-by: LitoMore <LitoMore@users.noreply.github.com>
@mondeja
Normalize usages of fs
a6846e7
@mondeja mondeja requested a review from LitoMore August 8, 2023 04:34
@mondeja mondeja merged commit 17ea889 into simple-icons:develop Aug 8, 2023
4 checks passed
@mondeja mondeja deleted the general-refactor branch August 8, 2023 04:38
@github-actions github-actions bot mentioned this pull request Aug 13, 2023
Merged
mondeja added a commit that referenced this pull request Aug 13, 2023
@mondeja
Release 5 new icons and 5 updated icons (v9.10.0)
c11c1d8 
# New Icons

- Clarivate (#9142)
- Distrokid (#9143)
- Google Bard (#9114)
- ImprovMX (#9004)
- InfoQ (#9148)

# Updated Icons

- Astro (#9201)
- SmugMug (#9237)
- Sourcegraph (#9174)
- Zcash (#9247)
- Zoom (#9211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mondeja @LitoMore