Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Chromatic icon #9132

Merged
merged 8 commits into from Aug 13, 2023
Merged

Adding Chromatic icon #9132

merged 8 commits into from Aug 13, 2023

Conversation

CodeWithShipraJain
Copy link
Contributor

@CodeWithShipraJain CodeWithShipraJain commented Jul 28, 2023 •
edited by adamrusted

Issue: closes #9111

Similarweb rank: 148,884. seen here: https://www.similarweb.com/website/chromatic.com/#overview

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jul 28, 2023
LitoMore
LitoMore requested changes Jul 28, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@CodeWithShipraJain
Copy link
Contributor Author

@LitoMore Kindly review the suggested changes.

@LitoMore
Copy link
Member

LitoMore commented Aug 3, 2023 •
edited

@CodeWithShipraJain Please hold your fire with the update branch button. All participants in the PR will receive an email and GitHub app notification when you pressing that button. Which is annoying.

In fact, there is no need to keep your branch updated to develop all the time. We will merge the develop branch before merging your PR.

I appreciate your understanding.

adamrusted
adamrusted approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @CodeWithShipraJain 🎉

@adamrusted adamrusted merged commit c0bf4f3 into simple-icons:develop Aug 13, 2023
3 checks passed
@CodeWithShipraJain CodeWithShipraJain deleted the 9111-chromatic branch August 16, 2023 11:53
@github-actions github-actions bot mentioned this pull request Aug 20, 2023
Merged
mondeja added a commit that referenced this pull request Aug 20, 2023
@mondeja
Release 32 new icons and 2 updated icons (v9.11.0)
11d0a68 
# New Icons

- (ISC)² (#9134)
- Arm Keil (#9167)
- Chromatic (#9132)
- CompTIA (#9157)
- Craftsman (#9207)
- Decap CMS (#9196)
- Ericsson (#9173)
- Flightaware (#9212)
- GameBanana (#9198)
- Hearth (#9234)
- Hexlet (#9296)
- Honor (#9239)
- htop (#7263)
- IGDB (#9288)
- JetBlue (#7046)
- League of Legends (#9297)
- LightBurn (#9102)
- Local (#9221)
- Milvus (#9215)
- MinIO (#6464)
- NATS.io (#9277)
- NEAR (#9131)
- October CMS (#9282)
- Piaggio Group (#9289)
- Retool (#9272)
- Rumble (#9216)
- Sanic (#9194)
- Singapore Airlines (#9187)
- Tata Consultancy Services (#9026)
- Vyond (#9168)
- Yeti (#9172)
- Zensar (#9273)

# Updated Icons

- Alipay (#9265)
- AniList (#9267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@LitoMore LitoMore Awaiting requested review from LitoMore

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Chromatic
4 participants
@CodeWithShipraJain @LitoMore @adamrusted @sjain-nrs