Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rumble Icon #9216

Merged
merged 6 commits into from Aug 17, 2023
Merged

Add Rumble Icon #9216

merged 6 commits into from Aug 17, 2023

Conversation

RiteshK-611
Copy link
Contributor

@RiteshK-611 RiteshK-611 commented Aug 5, 2023 •
edited by service-paradis

Issue: closes #8495

Similarweb rank:
The Similarweb site for Rumble is https://www.similarweb.com/website/rumble.com/

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Preview

rumble

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 5, 2023
PratyushJayachandran
PratyushJayachandran requested changes Aug 9, 2023
View reviewed changes
icons/rumble.svg Outdated Show resolved Hide resolved
RiteshK-611 and others added 2 commits August 12, 2023 22:02
@RiteshK-611 @PratyushJayachandran
Update icons/rumble.svg
1736817 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@RiteshK-611
Merge branch 'develop' into add_rumble_svg
f0336c0
PratyushJayachandran
PratyushJayachandran approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good 😊

@RiteshK-611
Copy link
Contributor Author

Seems good 😊

Then who is gonna Merge it?

@PratyushJayachandran
Copy link
Member

Then who is gonna Merge it?

I cannot. I don't have permissions😅

@RiteshK-611
Copy link
Contributor Author

Then who is gonna Merge it?

I cannot. I don't have permissions😅

No problem 🙂
Can you add reviewer who can merge it?

adamrusted
adamrusted requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon itself is spot on, just the one change needed to the hex code to match the one found in the SVG.

_data/simple-icons.json Outdated Show resolved Hide resolved
@RiteshK-611
Update _data/simple-icons.json
b0fa96c 
Co-authored-by: Adam Rusted <hello@adamrusted.me>
adamrusted
adamrusted approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @RiteshK-611 🎉

@adamrusted adamrusted merged commit ab1438f into simple-icons:develop Aug 17, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 20, 2023
Merged
mondeja added a commit that referenced this pull request Aug 20, 2023
@mondeja
Release 32 new icons and 2 updated icons (v9.11.0)
11d0a68 
# New Icons

- (ISC)&#178; (#9134)
- Arm Keil (#9167)
- Chromatic (#9132)
- CompTIA (#9157)
- Craftsman (#9207)
- Decap CMS (#9196)
- Ericsson (#9173)
- Flightaware (#9212)
- GameBanana (#9198)
- Hearth (#9234)
- Hexlet (#9296)
- Honor (#9239)
- htop (#7263)
- IGDB (#9288)
- JetBlue (#7046)
- League of Legends (#9297)
- LightBurn (#9102)
- Local (#9221)
- Milvus (#9215)
- MinIO (#6464)
- NATS.io (#9277)
- NEAR (#9131)
- October CMS (#9282)
- Piaggio Group (#9289)
- Retool (#9272)
- Rumble (#9216)
- Sanic (#9194)
- Singapore Airlines (#9187)
- Tata Consultancy Services (#9026)
- Vyond (#9168)
- Yeti (#9172)
- Zensar (#9273)

# Updated Icons

- Alipay (#9265)
- AniList (#9267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@PratyushJayachandran PratyushJayachandran PratyushJayachandran approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request icon: Rumble
3 participants
@RiteshK-611 @PratyushJayachandran @adamrusted