Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Local Icon #9221

Merged
merged 10 commits into from Aug 15, 2023
Merged

Add Local Icon #9221

merged 10 commits into from Aug 15, 2023

Conversation

nirajgiriXD
Copy link
Contributor

Issue: closes #9202

Similarweb rank:
Global rank: 152,120

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • The SVG viewbox is 0 0 24 24

Description

Added local logo in icons folder and updated simple-icons.json file with icon's data.

Preview

local-icon-preview

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 6, 2023
icons/local.svg Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
nirajgiriXD and others added 3 commits August 8, 2023 17:18
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors seem to be fixed. I haven't checked with source though.

@oohsai
Copy link

oohsai commented Aug 11, 2023

Hey! Glad if you could help me. How did you perform the "SVG viewbox is 0 0 24 24' check? I do have the svg file with me already

@PratyushJayachandran
Copy link
Member

PratyushJayachandran commented Aug 11, 2023

Hey! Glad if you could help me. How did you perform the "SVG viewbox is 0 0 24 24' check? I do have the svg file with me already

I just set the canvas size to 24x24 then center the icon.
npm run lint for running tests

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nirajgiriXD 🎉

@adamrusted adamrusted merged commit 3e5c856 into simple-icons:develop Aug 15, 2023
3 checks passed
mondeja added a commit that referenced this pull request Aug 20, 2023
# New Icons

- (ISC)&#178; (#9134)
- Arm Keil (#9167)
- Chromatic (#9132)
- CompTIA (#9157)
- Craftsman (#9207)
- Decap CMS (#9196)
- Ericsson (#9173)
- Flightaware (#9212)
- GameBanana (#9198)
- Hearth (#9234)
- Hexlet (#9296)
- Honor (#9239)
- htop (#7263)
- IGDB (#9288)
- JetBlue (#7046)
- League of Legends (#9297)
- LightBurn (#9102)
- Local (#9221)
- Milvus (#9215)
- MinIO (#6464)
- NATS.io (#9277)
- NEAR (#9131)
- October CMS (#9282)
- Piaggio Group (#9289)
- Retool (#9272)
- Rumble (#9216)
- Sanic (#9194)
- Singapore Airlines (#9187)
- Tata Consultancy Services (#9026)
- Vyond (#9168)
- Yeti (#9172)
- Zensar (#9273)

# Updated Icons

- Alipay (#9265)
- AniList (#9267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local
4 participants