Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now we can do SimpleCov.add_group "Group", ["path", "other/path"] #104

Closed
wants to merge 1 commit into from
Closed

Conversation

marcofognog
Copy link

This commit makes it possible to define a group with multiple directories.

SimpleCov.configuration do
add_group "Units", ["app/models", "lib", "app/helpers"]
end

By the way, great gem, very easy to read, well commented.

@ghost ghost assigned colszowka May 10, 2012
@colszowka
Copy link
Collaborator

Thanks for your submission, you have not been forgotten :)

I'm considering modifying the API for this so the filters and groups accept argument splats, so the line would look like this: add_group "Units", 'app/models', 'lib', 'app/helpers' (while retaining the ability to pass in an array, so %w(app/models lib) also works).

I hope I'll have the time to dive into this soon.

@misham
Copy link

misham commented Feb 5, 2013

Any movement on this? Would be nice to be able to provide multiple locations for the same group

@ronwsmith
Copy link

+1

2 similar comments
@zoran
Copy link

zoran commented Jan 10, 2014

+1

@jmthomas
Copy link

+1

@bf4
Copy link
Collaborator

bf4 commented Jul 13, 2014

Would you mind rebasing this off of master?

@sferik sferik force-pushed the master branch 2 times, most recently from 689480e to ec43ea9 Compare September 20, 2014 05:57
JanStevens pushed a commit to playpasshq/simplecov that referenced this pull request Mar 3, 2015
JanStevens pushed a commit to playpasshq/simplecov that referenced this pull request Mar 13, 2015
@sferik sferik force-pushed the master branch 9 times, most recently from c7c5ad5 to 4c39fa3 Compare April 18, 2015 12:02
sferik added a commit that referenced this pull request Apr 18, 2015
Added feature from #104 allowing a array to be passed in a filter
@sferik sferik force-pushed the master branch 6 times, most recently from fd640fa to 739cf4d Compare April 19, 2015 05:53
@onebree
Copy link
Contributor

onebree commented Apr 20, 2015

Since #375 was merged and recognized as the new version of this PR, can this one be closed?

@sferik
Copy link
Collaborator

sferik commented Apr 20, 2015

@onebree Yes, I believe so.

@sferik sferik closed this Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants