Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature from #104 allowing a array to be passed in a filter #375

Merged
merged 3 commits into from Apr 18, 2015

Conversation

JanStevens
Copy link

After two years of waiting we finally can use arrays in simplecov groups

Thanks for the original PR #104 since the author did not respond after 2 years I decided to copy past the PR based on the master branch.

@JanStevens
Copy link
Author

I have no clue why Travis is failing, if anyone can help

@colszowka
Copy link
Collaborator

Thanks! The tests broke because we had an order issue, see #362 and #372

I have three requests for you:

  • Please rebase/force push against master so this gets green
  • Could you please update the relevant section of the README with examples
  • And finally, a cucumber feature for this would be great - I think expanding this one should suffice.

Thanks!

@JanStevens
Copy link
Author

Allright, done everything!

I just added a small example to the README, I hope it suffices

@JanStevens
Copy link
Author

bump any update on this when this will be merged/released?

@bf4
Copy link
Collaborator

bf4 commented Apr 1, 2015

@colszowka ok with you?

@bf4 bf4 added the Feature label Apr 1, 2015
@sferik sferik force-pushed the master branch 9 times, most recently from c7c5ad5 to 4c39fa3 Compare April 18, 2015 12:02
sferik added a commit that referenced this pull request Apr 18, 2015
Added feature from #104 allowing a array to be passed in a filter
@sferik sferik merged commit 6587a96 into simplecov-ruby:master Apr 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants