Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ownership from constructors #7

Closed
simpleigh opened this issue Jan 6, 2019 · 0 comments
Closed

Remove ownership from constructors #7

simpleigh opened this issue Jan 6, 2019 · 0 comments

Comments

@simpleigh
Copy link
Owner

The AbstractBlock constructor takes an initialRow: Row (sensible) and an ownership: BlockOwnership (possibly less so). Passing the ownership in the constructor is sometimes convenient, but it might be best to remove this:

  • smaller constructors are good
  • we can simplify methods by setting the parent in AbstractContainer rather than each createSix call (although this does still need the index anyway)
  • this unlocks the possibility of creating a .subscribe() method on AbstractBlock offering more flexibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant