Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsecure IRC Client connection #70

Closed
tstavropoulos opened this issue Sep 12, 2020 · 2 comments
Closed

Unsecure IRC Client connection #70

tstavropoulos opened this issue Sep 12, 2020 · 2 comments
Labels

Comments

@tstavropoulos
Copy link

The IrcClient appears to open an unencrypted TCP connection to the irc server, and sends the Password (or OAuth token) in plaintext.

This can (and probably should) be rewritten to use SSL (documented here).

@SimpleSandman
Copy link
Owner

Ah good find! I'll have to work on that the next chance I get.

I assume something like this answer:
https://stackoverflow.com/questions/8375013/how-to-use-ssl-in-tcpclient-class

@tstavropoulos
Copy link
Author

Truth be told, I'm not sure offhand what a proper IRC-over-SSL implementation might look like, but that doesn't look wrong to me. I just wanted to raise the issue that I was able to identify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants