ReferenceExpectation scalar bug

[mal]

Transfering my comment from the now defunct #8 to an issue to be actively looked into.

tl;dr

• Allow use of ReferenceExpectation in expect calls (-PHP4) #7 fundamentally broke ReferenceExpectation for everything but objects.
• Allow use of ReferenceExpectation in expect calls #5 achieves the goals of Allow use of ReferenceExpectation in expect calls (-PHP4) #7 in the simplest way possible without breaking anything.
• Please revert Allow use of ReferenceExpectation in expect calls (-PHP4) #7 and consider re-opening/merging Allow use of ReferenceExpectation in expect calls #5. PR can be found in Fix reference expectation #11.

Hmmm, seems those fails are valid. Looking at them I also suspect that #7 has introduced some potential pit falls. I think perhaps #5 was the way to go after all.

Problem is those ampersands are needed (objects are implicitly byref in PHP5, but scalars and arrays are not). Unfortunately that means it can't inherit (warnings to do with differing method signatures) so the separate class and just tweaking the isExpectation method was probably the safest change afterall!

Recommend reopening #5 and reverting #7 merging #11.

Sorry for the confusion 😞