Allow use of ReferenceExpectation in expect calls (-PHP4) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make ReferenceExpectation inherit from EqualException so it will be recognised by SimpleExpectation::isExpectation.
mal
changed the title
jakoch
added a commit
that referenced
this pull request
Jul 27, 2015
Allow use of ReferenceExpectation in expect calls
|
Any speculation as to when this might find it's way into a composered release? |
|
I would like to see the tests go green again, before i tag a new release. Some additional cleanups need to be done on the repository to get it in a better shape for distribution with Composer. At the moment a lot of unnecessary stuff (like the website) is distributed with each |
|
Wow, I didn't appreciate that, but it makes sense. Thanks for being so responsive and keeping the project chugging along after all these years! 😀 |
This was referenced Jul 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ReferenceExpectation inherit from EqualException so it will be
recognised by SimpleExpectation::isExpectation.
Alternate approach to #5 that doesn't maintain PHP4 compat.