PHP 5 doesn't need these, and later versions warn #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some isReference() related tests fail after this change. |
|
Hmmm, seems those fails are valid. Looking at them I also suspect that that last PR has introduced some potential pit falls. I think perhaps the original PR was the way to go after all. Problem is those ampersands are needed (objects are implicitly byref in PHP5, but scalars and arrays are not). Unfortunately that means it can't inherit (warnings to do with differing method signatures) so the separate class and just tweaking the Recommend Sorry for the confusion 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed to commit without these when throwing together the previous PR! >_>;;