Allow use of ReferenceExpectation in expect calls #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReferenceExpectation does not inherit from EqualException (it's logical parent), and is unable to do so while maintaining PHP4 compatability (the byref ampersands would need removing) so instead, add a case to recognise it as a valid exception in SimpleExpectation::isExpectation.
|
You don't have to maintain PHP4 compatibility. (I've already removed the reflection helper for PHP4.) Ok.. closing (in favor of your other pull request). |
This was referenced Jul 28, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReferenceExpectation does not inherit from EqualException (it's logical parent), and is unable to do as it cannot maintain method signature compatability (the byref ampersands are the cause of that) so instead, add a case to recognise it as a valid exception in SimpleExpectation::isExpectation.