Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Add test which fails if self.evaluator = None is removed #88

Closed
adamtheturtle opened this issue Oct 11, 2023 · 2 comments
Closed

Request: Add test which fails if self.evaluator = None is removed #88

adamtheturtle opened this issue Oct 11, 2023 · 2 comments

Comments

@adamtheturtle
Copy link
Contributor

PythonDocument.evaluator in sybil/document.py includes the line self.evaluator = None.
mypy has issues with this line, and I am trying to resolve those issues.
However, I cannot be confident that my attempts are valid, as I don't understand what this is meant to do, and the tests pass if this line is removed.
My request is that a test is added which fails if this line is removed, so that I can have more confidence.
@cjw296
Copy link
Member

cjw296 commented Oct 12, 2023

This ends up going away in the branch I'm currently working on.

@cjw296 cjw296 closed this as completed Oct 12, 2023
@adamtheturtle
Copy link
Contributor Author

Thanks! I'll wait for that

@cjw296 cjw296 linked a pull request Oct 19, 2023 that will close this issue
Skip improvements #94
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip improvements simplistix/sybil
2 participants
@cjw296 @adamtheturtle