Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking any item inside gui with off-hand causes duplication! #21

Closed
HW2955 opened this issue Sep 13, 2022 · 1 comment
Closed

Clicking any item inside gui with off-hand causes duplication! #21

HW2955 opened this issue Sep 13, 2022 · 1 comment

Comments

@HW2955
Copy link

HW2955 commented Sep 13, 2022

(Tested with this environment)
Paper-341 (1.18.2)
Java 17.0.3.1

  • cirrus-spigot-example-2.0.0
  • EssentialxxX-2.19.4
  • FAWE-Bukkit-2.3.1
  • Skript 2.6.3
  • Vault

Actions to replicate:

  1. Use the /test command from example usage plugin,
  2. Click the 'F' key (switch to off-hand) while cursor is on any item,
    2.1. This produces an error (error.txt)
  3. Close the menu,
  4. (Note: while player is in survival mode, this only produces a ghost item, though creative mode creates it.)
    Open your inventory (probably works with opening other inventories aswell)
  5. Get duplicated item in your off-hand slot.

Hopefully someone smart enough finds a good fix for this, I've fixed this bug in my framework by adding NBT tag to all gui-items and removing them wherever player causes InventoryClickEvent, though i don't find it really optimal solution.

I really love this framework and would love to see it being expanded upon, and documentation being published.

@KotlinFactory
Copy link
Member

Hi, this Cirrus version is very outdated. Please use 2.1.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants