Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop thin support #1627

Merged
merged 7 commits into from Aug 8, 2020
Merged

Drop thin support #1627

merged 7 commits into from Aug 8, 2020

Conversation

@rkmathi
Copy link
Contributor

@rkmathi rkmathi commented Jul 26, 2020

fixes #1624

Remove thin to drop support.
Use puma or rainbows instead of thin.

@rkmathi rkmathi mentioned this pull request Jul 26, 2020
Copy link
Contributor

@namusyaka namusyaka left a comment

Hey Ryuichi, thanks for working on this! Mostly looks good, but please review a few points I commented.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
lib/sinatra/base.rb Show resolved Hide resolved
test/integration_test.rb Show resolved Hide resolved
@rkmathi rkmathi force-pushed the rkmathi:rkmathi/drop-thin-support branch from c6d3e34 to 7010c30 Jul 28, 2020
@rkmathi rkmathi requested a review from namusyaka Jul 28, 2020
Copy link
Contributor

@namusyaka namusyaka left a comment

Hey Ryuichi,
Thanks for continuing your efforts. Please take a look at my comments.

@rkmathi rkmathi force-pushed the rkmathi:rkmathi/drop-thin-support branch 5 times, most recently from a032ccb to 96d1f0b Aug 1, 2020
@rkmathi rkmathi requested a review from namusyaka Aug 5, 2020
Copy link
Contributor

@namusyaka namusyaka left a comment

LGTM with a few nits. Thanks so much for your hard working on the complex issue!

@@ -3,7 +3,6 @@
# run *one* of these:
#
# rackup -s mongrel stream.ru # gem install mongrel
# thin -R stream.ru start # gem install thin

This comment has been minimized.

@namusyaka

namusyaka Aug 8, 2020
Contributor

Please copy test/integration/rainbows.conf here and add rainbows -c rainbows.conf stream.ru.

This comment has been minimized.

@rkmathi

rkmathi Aug 8, 2020
Author Contributor

fixed 7a96472

@@ -1,6 +1,10 @@
$stderr.puts "loading"
require 'sinatra'

if RUBY_ENGINE == "ruby"
require_relative './rainbows'
end

This comment has been minimized.

@namusyaka

namusyaka Aug 8, 2020
Contributor

require_relative 'rainbows' if RUBY_ENGINE == 'ruby'

This comment has been minimized.

@rkmathi rkmathi force-pushed the rkmathi:rkmathi/drop-thin-support branch from 96d1f0b to 7a96472 Aug 8, 2020
@rkmathi
Copy link
Contributor Author

@rkmathi rkmathi commented Aug 8, 2020

@namusyaka I fixed.
Thank you for reviewing and helping me a lot!

@rkmathi rkmathi requested a review from namusyaka Aug 8, 2020
Copy link
Contributor

@namusyaka namusyaka left a comment

Awesome!

@namusyaka namusyaka merged commit f57acef into sinatra:master Aug 8, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rkmathi added a commit to rkmathi/sinatra that referenced this pull request Aug 8, 2020
@jkowens
Copy link
Member

@jkowens jkowens commented Aug 8, 2020

Great work @rkmathi! 💯 👏

@namusyaka namusyaka added this to the v2.1.0 milestone Aug 30, 2020
jkowens added a commit that referenced this pull request Oct 1, 2020
Update README.es.md to follow #1627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.