Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to complete DockProgress in 4.3.0 version #20

Closed
Kyle-Ye opened this issue Mar 25, 2024 · 3 comments
Closed

How to complete DockProgress in 4.3.0 version #20

Kyle-Ye opened this issue Mar 25, 2024 · 3 comments

Comments

@Kyle-Ye
Copy link

Kyle-Ye commented Mar 25, 2024

In the 3.2.0 version, if we set the progress value to "1.0". The extra dock progress will be hidden.

let icon = (0..<1).contains(progress) ? draw(appIcon) : appIcon

The above logic does not seem to have been retained in the latest version 4.3.0.

Related Issue: XcodesOrg/XcodesApp#529 (comment)

@Kyle-Ye Kyle-Ye changed the title How to remove DockProgress in 4.3.0 How to complete DockProgress in 4.3.0 version Mar 25, 2024
@sindresorhus
Copy link
Owner

Would you be able to try out this commit? d4f23b5

@Kyle-Ye
Copy link
Author

Kyle-Ye commented Mar 30, 2024

Would you be able to try out this commit? d4f23b5

Tried it. It works.

Would you minding releasing a new version (eg. 4.3.1 or 4.4.0) for it? Thanks

See XcodesOrg/XcodesApp#545

@sindresorhus
Copy link
Owner

https://github.com/sindresorhus/DockProgress/releases/tag/4.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants