Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is @types/react required? #16

Closed
aladdin-add opened this issue Sep 10, 2019 · 1 comment
Closed

is @types/react required? #16

aladdin-add opened this issue Sep 10, 2019 · 1 comment

Comments

@aladdin-add
Copy link

auto-bind/package.json

Line 38 in 2579065

"@types/react": "^16.8.12"

I'm not using react, but the @types/react is installed. …（⊙＿⊙；）…
@aladdin-add aladdin-add mentioned this issue Sep 10, 2019
Closed
@kevva
Copy link

kevva commented Sep 10, 2019 •
edited

It's used for the TypeScript definition. Ideally it'd be a peer dependency, but there are probably a lot of TypeScript consumers of this module that doesn't use React which then would cause errors because @types/react isn't installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevva @aladdin-add