Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about AVA mantra in contributing guidelines #664

Merged
merged 1 commit into from
Mar 22, 2016

Conversation

kentcdodds
Copy link
Contributor

See this PR which inspired this addition to contributing.md :-)

@jamestalmage
Copy link
Contributor

👍 I like this.

We have run into this a number of times (.avarc requests, config/ava vs ava in package.json, etc). It would be kinder to contributors to explain this up front.

@novemberborn
Copy link
Member

+1 for merging this as-is, we can do other clarifications as a follow-up.

@novemberborn
Copy link
Member

See also #175 (comment)

jamestalmage added a commit that referenced this pull request Mar 22, 2016
add note about AVA mantra in contributing guidelines
@jamestalmage jamestalmage merged commit f2c0709 into avajs:master Mar 22, 2016
@kentcdodds kentcdodds deleted the pr/update-contributing branch March 22, 2016 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants