Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Friday Night Funkin' Resources #2503

Closed
wants to merge 2 commits into from
Closed

Add Friday Night Funkin' Resources #2503

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2023

add this list

this list is all about fnf and i was wondering if i can put it here lol

this list is made by @FunkinCrew (fnf developers), not me

By submitting this pull request I confirm I've read and complied with the below requirements πŸ––

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting β€œlooks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • βœ… Add Swift
    • βœ… Add Software Architecture
    • ❌ Update readme.md
    • ❌ Add Awesome Swift
    • ❌ Add swift
    • ❌ add Swift
    • ❌ Adding Swift
    • ❌ Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • βœ… - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • βœ… - [Framer](…) - Prototyping interactive UI designs.
    • ❌ - [iOS](…) - Resources and tools for iOS development.
    • ❌ - [Framer](…)
    • ❌ - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The title of your entry should be title-cased and the URL to your list should end in #readme.
    • Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • βœ… Mobile operating system for Apple phones and tablets.
    • βœ… Prototyping interactive UI designs.
    • ❌ Resources and tools for iOS development.
    • ❌ Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • βœ… awesome-swift
    • βœ… awesome-web-typography
    • ❌ awesome-Swift
    • ❌ AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • βœ… # Awesome Swift
    • βœ… # Awesome Web Typography
    • ❌ # awesome-swift
    • ❌ # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't use hard-wrapping.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! πŸ™Œ

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@ghost
Copy link
Author

ghost commented Jan 30, 2023

I DIDN'T MADE IT, @FunkinCrew MADE THIS LIST AAAAAAAAAAAAAAAAAA!

nobody submitted it so i should do it

@ghost
Copy link
Author

ghost commented Jan 31, 2023

unicorn

@vhladiienko
Copy link
Contributor

vhladiienko commented Jan 31, 2023

Hi @lime360

I think your PR misses some love:

  1. Link other PRs in this repo, that you have reviewed or commented on
  2. Your list entry should be at the bottom of the category you're updating

As for the list itself, it needs some adjustments too.

  1. First of all, make sure it passes linting. This will cover most of the issues with the current revision.
  2. "Further reading" section should be moved to the Footnotes section.

Even though you're not the author of the list, I'm sure you can contribute to make the list comply with the requirements.

@Karneades
Copy link
Contributor

Karneades commented Jan 31, 2023

@lime360 I understood that someone else created that list. To support Sindre a bit, I comment on this issue.

As Sindre noted above, for a list to be included in the awesome-list, that list should fulfill various requirements. When looking at the repo, many things from the guidelines are still to be improved / changed. @FunkinCrew must change some of the project settings (setting topics, change repo name) and the list itself must be improved according to the guidelines.

Hope you keep working on the list that it gets merged. For new lists there is also #2242 which would be the place for such a list in "draft" mode for the future.

@Superlegend717
Copy link

Hello sir,iam a learner i need to know how can i operate termux in an android,please!

@ghost
Copy link
Author

ghost commented Feb 2, 2023

@Superlegend717 i am sorry but this is off-topic.

@Superlegend717
Copy link

Ok,thank you so much for respond.

@vhladiienko vhladiienko mentioned this pull request Feb 2, 2023
@ghost
Copy link
Author

ghost commented Feb 5, 2023

i edited my first pr message

@EliteMasterEric
Copy link

Hey,

I am a maintainer for the Friday Night Funkin' Resources repository. I will be looking through this thread and attempting to fix the issues I can. Feel free to @ me if you have any other concerns.

@@ -547,6 +547,7 @@
- [Minecraft](https://github.com/bs-community/awesome-minecraft#readme) - Sandbox video game.
- [Game Datasets](https://github.com/leomaurodesenv/game-datasets#readme) - Materials and datasets for Artificial Intelligence in games.
- [Haxe Game Development](https://github.com/Dvergar/awesome-haxe-gamedev#readme) - A high-level strongly typed programming language used to produce cross-platform native code.
- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources#readme) - A rhythm game made in HaxeFlixel.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this line to read the following:

- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources) - A cartoon rhythm game made for Newgrounds.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks better

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the guidelines, the #readme is required which is also more user friendly to directly jump to it when opening the link.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so the correct description should be:

- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources#readme) - A cartoon rhythm game made for Newgrounds.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is incorrect

@EliteMasterEric
Copy link

As of time of writing, the only pending issue I am aware of on the Funkin' Resources repository is the age one. All other linting issues have been resolved.

Please feel free to provide any additional feedback or PRs if necessary.

@Karneades
Copy link
Contributor

As of time of writing, the only pending issue I am aware of on the Funkin' Resources repository is the age one. All other linting issues have been resolved.

Please feel free to provide any additional feedback or PRs if necessary.

Nice improvements since last time I looked over it 2 weeks ago. The repo name as required by the guidelines needs an "awesome-..." prefix.

  • See part around The repo name of your list should be in lowercase slug format: awesome-name-of-list.

@EliteMasterEric
Copy link

The repo name as required by the guidelines needs an "awesome-..." prefix.

* See part around _The repo name of your list should be in lowercase slug format: awesome-name-of-list._

Ah, I misunderstood this, I interpreted that statement as "the repo must be in lower kebab case" and not "the repo must be in lower kebab case and start with awesome-".

I will look into getting it changed.

@EliteMasterEric
Copy link

At time of writing, ALL KNOWN ISSUES ARE CURRENTLY FIXED, including the one regarding repo age.

The repository now passes all linting checks.

@EliteMasterEric
Copy link

The workflow will need to be re-run in order for GitHub to validate the changes.

@@ -547,6 +547,7 @@
- [Minecraft](https://github.com/bs-community/awesome-minecraft#readme) - Sandbox video game.
- [Game Datasets](https://github.com/leomaurodesenv/game-datasets#readme) - Materials and datasets for Artificial Intelligence in games.
- [Haxe Game Development](https://github.com/Dvergar/awesome-haxe-gamedev#readme) - A high-level strongly typed programming language used to produce cross-platform native code.
- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources#readme) - A rhythm game made in HaxeFlixel.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so the correct description should be:

- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources#readme) - A cartoon rhythm game made for Newgrounds.

Copy link
Contributor

@eric-hc eric-hc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo name should be prefixed with awesome-

image

@eric-hc eric-hc mentioned this pull request Mar 23, 2023
32 tasks
@jacobdjwilson
Copy link

It may make sense to use Instead use #2242 for further definition of this list.

@EliteMasterEric
Copy link

It may make sense to use Instead use #2242 for further definition of this list.

Incorrect. This list is only pending the resolution of minor fixes before being reapproved for submission.

@sindresorhus
Copy link
Owner

The readme header should be Awesome Friday Night Funkin', not Friday Night Funkin' Resources.

@ghost ghost closed this by deleting the head repository Jun 30, 2023
@jacobdjwilson jacobdjwilson mentioned this pull request Nov 7, 2023
32 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants