New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Control Theory #2569
Add Control Theory #2569
Conversation
Thanks for making an Awesome list! π It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Fixed lints regarding List item links... The only lint error left is 'Missing main list heading' since linting cannot find the HTML header. The same error appears when linting https://github.com/sindresorhus/awesome |
Hi @A-make! I like your list, thanks for sharing the map and the resources, I might take a look when I'm feeling smart. However, there are still some formatting problems that don't pass the guidelines. I quite like the tabular format for books & courser, but I don't think it's accepted.
Overall, I'd suggest a format like this:
Besides, I'm not 100% sure, but I'd move the title above the illustration. Don't forget the secret sauce (look really close at the guidelines). Also, contributing guidelines are really detailed, well done! I'm sure you'll be able to make it here, soon. |
unicorn |
@@ -529,6 +529,7 @@ | |||
- [Recursion Schemes](https://github.com/passy/awesome-recursion-schemes#readme) - Traversing nested data structures. | |||
- [Audit Algorithms](https://github.com/erwanlemerrer/awesome-audit-algorithms#readme) - Algorithmic audits of algorithms. | |||
- [AGI & CoCoSci](https://github.com/YuzheSHI/awesome-agi-cocosci#readme) - The reciprocation of Artificial General Intelligence (AGI) and Computational Cognitive Sciences (CoCoSci). | |||
- [Control Theory](https://github.com/A-make/awesome-control-theory#readme) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a short introduction here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a short introduction here.
Yes I will
Thanks for the list. It looks interesting. Here are a few comments that might be helpful:
|
@A-make Submitted a PR A-make/awesome-control-theory#7 to your Awesome list which fixes the linting issues by converting the HTML section below to Markdown.
|
Closing for lack of response. |
Sorry, been away on other projects for a good while.. Thank you all for you comments. Will address them and create a new PR.
Thank you @DenisCarriere. Your PR has been merged and along with a few more minor changes the awesome-list linter in now passing π |
https://github.com/A-make/awesome-control-theory
Provides resources on Control Theory and Control Engineering. Getting pretty good traction.
By submitting this pull request I confirm I've read and complied with the below requirements π
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting βlooks goodβ or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](β¦) - Mobile operating system for Apple phones and tablets.
- [Framer](β¦) - Prototyping interactive UI designs.
- [iOS](β¦) - Resources and tools for iOS development.
- [Framer](β¦)
- [Framer](β¦) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](β¦) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.