Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fish #636

Merged
merged 1 commit into from Jun 18, 2016
Merged

Add Fish #636

merged 1 commit into from Jun 18, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2016

Add fish.

Would love to have the awesome fish list here, but feel free to decline if this is out of the scope of awesome.

Cheers.

@sindresorhus
Copy link
Owner

Yes, happy to have it, but I think the lists needs a little bit more work.

  • Can you put all the badges in the same place (including the awesome badge)? Would look best on the right side of the main heading, but could also be below, but having it above looks messy.
  • Awesome fish-shell => Awesome fish shell
  • Add a contributing.md file. Example: https://github.com/sindresorhus/awesome-nodejs/blob/master/contributing.md And link to it from the Contributing section.
  • The repo description is not in sync with the readme one.
  • You only list tools. Would be useful with some articles, learning material, videos, books, etc, about fish.
  • Add some community resources. Example: https://github.com/sindresorhus/awesome-electron#community
  • Not clear what the difference between Classic and Powerline is.
  • Include the fish logo in the readme. Example: https://github.com/sindresorhus/awesome-electron
  • Most of the for fish-shell. in the descriptions are moot.
  • Drop the build passing badge. Not required, but it doesn't have much purpose. I realize you use Travis to check for valid PRs, but the badge doesn't have much purpose and is mostly just distracting.

@ghost
Copy link
Author

ghost commented May 1, 2016

Drop the build passing badge. Not required, but it doesn't have much purpose. I realize you use Travis to check for valid PRs, but the badge doesn't have much purpose and is mostly just distracting.

What about adding the build and slack room badge at the bottom?

Nevermind that.

@sindresorhus sindresorhus changed the title Add fish-shell to Development Environment section. Add Fish May 1, 2016
@ghost
Copy link
Author

ghost commented May 1, 2016

@sindresorhus 90% coverage of your requirement list.

Include the fish logo in the readme.

There is none. I find the existing "unofficial" logo too unattractive to add it to the page.

You only list tools. Would be useful with some articles, learning material, videos, books, etc, about fish.

Yep, I'll create a section for that and start adding content as I find it.

@sindresorhus
Copy link
Owner

There is none, or it's not well defined. The existing "unofficial" logo is too ugly.

Doesn't look too bad: http://ridiculousfish.com/shell/images/fishfish_logo.png Maybe you could do something with it if you don't like it. Totally optional though. Just that some illustrations really help make an awesome list truly awesome. Example of an awesome header illustration: https://github.com/websemantics/awesome-synthetic-biology

@sindresorhus
Copy link
Owner

Okay, I'll create a section for that and start adding content as I find it.

Maybe also some popular dotfiles repos using fish.

@ghost
Copy link
Author

ghost commented May 1, 2016

Maybe also some popular dotfiles repos using fish.

I'll look (again), but most of the things I have seen is people using a mix of bash/zsh with some fish nuggets, but not using fish as their main shell (which would be desirable in this case).

Doesn't look too bad: http://ridiculousfish.com/shell/images/fishfish_logo.png

Haha. Anyway, I think something like awesome-synthetic-biology would be really special. I'll try to come up with a jumbo-like screen artwork.

EDIT:

Issues for (some of) your suggestions.

@sindresorhus
Copy link
Owner

Btw, here's the command to print the logo: fish-shell/fish-shell#114 (comment) So you can get it in any size ;)

@ghost
Copy link
Author

ghost commented May 1, 2016

@sindresorhus Thanks for the link. I'll try to come up with an original cover art.

@@ -276,6 +276,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht
- [Dev Env](https://github.com/jondot/awesome-devenv)
- [Dotfiles](https://github.com/webpro/awesome-dotfiles)
- [Shell](https://github.com/alebcay/awesome-shell)
- [Fish](https://github.com/fisherman/awesome-fish)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the link to the new repository location: https://github.com/brj/awesome-fish and also indent the bullet point so it is forms under the Shell list.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davisonio Fixed by moving the repo back to the org.

@sindresorhus
Copy link
Owner

ping :)

@ghost
Copy link
Author

ghost commented Jun 8, 2016

@sindresorhus I didn't get around completing the artwork, because I was not happy with the result.

  • Can you put all the badg...
  • Awesome fish-shell => Awesome fish shell
  • Add a contributing.md f...
  • The repo description is not in sync with the readme one.
  • You only list tools. Would be useful with some articles, ...

    I know it needs more, but ... https://github.com/fisherman/awesome-fish#community

  • Add some community resource...
  • Not clear what the difference...
  • Include the fish logo in the.......
  • Most of the for fish-shell...
  • Drop the build passing badge. Not required, but it doesn't have much purpose. I realize you use Travis to check for valid PR...

@sindresorhus sindresorhus merged commit 8ac95da into sindresorhus:master Jun 18, 2016
@sindresorhus
Copy link
Owner

Landed. Didn't want to wait anymore.

amsharma91 added a commit to amsharma91/awesome that referenced this pull request Sep 27, 2016
parinck pushed a commit to parinck/awesome that referenced this pull request Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants