Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Asyncio #846

Merged
merged 3 commits into from Jan 10, 2017
Merged

Add Python Asyncio #846

merged 3 commits into from Jan 10, 2017

Conversation

timofurrer
Copy link
Contributor

https://github.com/timofurrer/awesome-asyncio

A curated list of awesome Python asyncio frameworks, libraries, software and resources.

By submitting this pull request I confirm I've read and complied with the below requirements.

Failure to properly do so will just result in the pull request being closed and everyone's time wasted. Please read it twice. Most people miss many things.

  • I have read and understood the contribution guidelines and the instructions for creating a list.
  • This pull request has a descriptive title. For example, Add Name of List, not Update readme.md or Add awesome list.
  • The entry in the Awesome list should include a short description about the list project/theme (not the list itself), and should be added at the bottom of the appropriate category.
  • The list I added
    • has been around for at least 30 days,
    • is the result of hard work and is the best I could possibly produce,
    • is a non-generated Markdown file in a GitHub repo,
    • is not a duplicate,
    • includes a succinct description of the project/theme at the top (example),
    • includes a project logo/illustration (whenever possible) at the top right of the readme (example). (The logo should link to the project website or any relevant website. The logo should be high-DPI, so set it to maximum half the width of the original image.),
    • only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
    • contains the awesome badge on the right side of the list heading,
    • has a Table of Contents section named Contents as the first section,
    • has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc) (If you use a license badge, it should be SVG, not PNG),
    • has contribution guidelines,
    • doesn't include a Travis badge,
    • has been checked for inconsistent formatting, spelling, and grammar:
      • Each link description starts with an uppercase character and ends with a period.
      • Drop all the A / An prefixes in the descriptions.
      • Consistent naming. For example, Node.js, not NodeJS or node.js.

This change adds the Python [awesome-asyncio](https://github.com/timofurrer/awesome-asyncio) list to this awesome list.

Thanks for this project 🍻
@sindresorhus
Copy link
Owner

Looks pretty good.


  • Readme heading should be "Awesome asyncio", not "awesome-asyncio"

includes a succinct description of the project/theme at the top (example),

Not followed. Should succinctly explain what asyncio is and why I should care ;)

@sindresorhus sindresorhus changed the title Add Python Asyncio list Add Python Asyncio Jan 10, 2017
@@ -90,6 +90,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht
- [Education](https://github.com/hsavit1/Awesome-Swift-Education)
- [Playgrounds](https://github.com/uraimo/Awesome-Swift-Playgrounds)
- [Python](https://github.com/vinta/awesome-python)
- [Asyncio](https://github.com/timofurrer/awesome-asyncio)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a very short description about asyncio. See other items with description for what format to use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@timofurrer
Copy link
Contributor Author

timofurrer commented Jan 10, 2017

I've added a succinct description to the README and changed the title.

Thanks for the review!

@sindresorhus sindresorhus merged commit 3f1f688 into sindresorhus:master Jan 10, 2017
parinck pushed a commit to parinck/awesome that referenced this pull request Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants