New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple string matching + wildcards failing #39

Closed
tillig opened this Issue Oct 3, 2014 · 5 comments

Comments

5 participants
@tillig

tillig commented Oct 3, 2014

I have an editorconfig that tries to make use of the multiple-string matching to keep things simple, but also wildcards:

[*]
end_of_line = CRLF
indent_style = tab

[{*.html,*.cshtml}]
indent_style = space
indent_size = 4

This seems to work in the Visual Studio plugin but not in Sublime Text 3 (registered).

When I open a .html file and look in the Sublime console I see the dictionary of settings and it only includes the ones from the [*] match.

However, if I change the file to:

[*]
end_of_line = CRLF
indent_style = tab

[*.cshtml]
indent_style = space
indent_size = 4

[*.html]
indent_style = space
indent_size = 4

Then my settings are correctly applied in both Sublime and Visual Studio.

Am I misusing the multi-string match function?

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus
Owner

sindresorhus commented Oct 3, 2014

@mrhyde

This comment has been minimized.

Show comment
Hide comment
@mrhyde

mrhyde Oct 7, 2014

Have exactly the same issue here. 😭

mrhyde commented Oct 7, 2014

Have exactly the same issue here. 😭

@ArmorDarks

This comment has been minimized.

Show comment
Hide comment
@ArmorDarks

ArmorDarks Oct 7, 2014

Same issue too. Sublime build 3065

ArmorDarks commented Oct 7, 2014

Same issue too. Sublime build 3065

@treyhunner

This comment has been minimized.

Show comment
Hide comment
@treyhunner

treyhunner Oct 13, 2014

Contributor

This is a problem with the Python core library not supporting nesting of special glob characters(*, ?, etc.) in braces ({ and }).

The incomplete pull request for adding support is at editorconfig/editorconfig-core-py#5. I started adding support and got stuck and then busy.

Contributor

treyhunner commented Oct 13, 2014

This is a problem with the Python core library not supporting nesting of special glob characters(*, ?, etc.) in braces ({ and }).

The incomplete pull request for adding support is at editorconfig/editorconfig-core-py#5. I started adding support and got stuck and then busy.

@treyhunner

This comment has been minimized.

Show comment
Hide comment
@treyhunner

treyhunner Oct 26, 2014

Contributor

I just released v0.12.0 of the EditorConfig Python library which supports nested brace expansion and numeric ranges.

@sindresorhus if you upgrade the Python library it will fix this issue.

Contributor

treyhunner commented Oct 26, 2014

I just released v0.12.0 of the EditorConfig Python library which supports nested brace expansion and numeric ranges.

@sindresorhus if you upgrade the Python library it will fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment