Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showInspectElement: false Causes unhandled exception #68

Closed
Rudedog9d opened this issue Apr 30, 2019 · 5 comments · Fixed by #69
Closed

showInspectElement: false Causes unhandled exception #68

Rudedog9d opened this issue Apr 30, 2019 · 5 comments · Fixed by #69
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@Rudedog9d
Copy link

Rudedog9d commented Apr 30, 2019

Issuehunt badges

Using the library in a global context with the following options causes an unhandled exception with every right click:

contextMenu({showInspectElement: false});

// causes this error
TypeError: Invalid template for MenuItem: must have at least one of label, role or type
    at Function.Menu.buildFromTemplate (D:\Users\<user>\Dev\excalibur\node_modules\electron\dist\resources\electron.asar\browser\api\menu.js:164:11)
    at WebContents.webContents.on (D:\Users\<user>\Dev\<project>\node_modules\electron-context-menu\index.js:182:74)
    at WebContents.emit (events.js:182:13)

This causes the context menu to not show up at all.

Windows 10 x64
using yarn
electron-context-menu@0.12.0

IssueHunt Summary

medusalix medusalix has been rewarded.

Sponsors (Total: $40.00)

Tips

@Rudedog9d
Copy link
Author

Also tested on electron-context-menu@0.12.1

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 2, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@medusalix
Copy link
Contributor

I'm working on a fix 😃.

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels May 29, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @medusalix. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@jvaes
Copy link

jvaes commented Jun 7, 2019

Any Idea when there will we an updated npm package with this Fix? I have to update the code manually on each npm install at the moment.

Thnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants