New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get "Download Error" when using save as dialog and cancel button is pressed #166

Closed

theogravity opened this issue Jan 30, 2024 · 1 comment · Fixed by #167

Contributor

theogravity commented Jan 30, 2024 •

edited

Loading

Not sure why it happens even though it's surrounded with a try / catch.

// main/index.ts
electronDl({
  saveAs: true,
});

// IPC handler
      try {
        await download(window, url, {
          saveAs: true,
          filename,
        });
      } catch (e) {
        this.log.withError(e).error('Unable to download file');
      }

Contributor Author

theogravity commented Jan 30, 2024

After more investigation, it seems I don't even need the await download() call to reproduce it. I just need to call:

mainWindow.webContents.downloadURL(..)

If I remove the electronDl() init call, then I won't get the error when canceling

theogravity mentioned this issue

Fix "Save As" cancellation showing error dialog #167

Merged

sindresorhus closed this as completed in #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment