Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape-case only catches first escape sequence in string #677

Closed
bmish opened this issue Apr 10, 2020 · 4 comments · Fixed by #678
Closed

escape-case only catches first escape sequence in string #677

bmish opened this issue Apr 10, 2020 · 4 comments · Fixed by #678
Assignees
@fisker
Labels
bug

Comments

@bmish
Copy link
Contributor

bmish commented Apr 10, 2020

I'm seeing escape-case only catch and autofix/uppercase the first escape sequence character.

Before: const x = '\uff10\uff11'
After: const x = '\uFF10\uff11'
@fisker
Copy link
Collaborator

fisker commented Apr 10, 2020

This rule only fix one character once, with --fix you'll get all fixed.

@bmish
Copy link
Contributor Author

bmish commented Apr 10, 2020

I'm a bit unsure what you mean? I did use eslint --fix but only the first escape sequence gets fixed.

@fisker fisker added the bug label Apr 10, 2020
@fisker
Copy link
Collaborator

fisker commented Apr 10, 2020

Right, I broke it in #534

@fisker fisker self-assigned this Apr 10, 2020
@fisker fisker mentioned this issue Apr 10, 2020
Merged
@fisker
Copy link
Collaborator

fisker commented Apr 10, 2020

Should be fixed by #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fisker fisker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

escape-case: Fix missing characters fisker/eslint-plugin-unicorn
2 participants
@fisker @bmish