Crash with input option and absolute path without execute permissions

[targos]

To reproduce, create /non-executable-file and don't give it execute permissions.

const execa = require('execa');
execa('/non-executable-file', { input: 'foo' });

It crashes here because stdin doesn't exist:

execa/index.js

Line 92 in bfc9a4e

spawned.stdin.end(input);

stroncium earned $30.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[IssueHuntBot]

@IssueHunt has funded $30.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[chinesedfan]

@targos Do you remember detailed environments? Like Node.js/OS/execa version. I failed to reproduce with Node8&10/OSX 10.14/execa 1.0.0. It throws an error during childProcess.spawn, but is caught by the next line immediately. Function handleInput is not executed at all.

[targos]

Node.js 11.12.0 / Linux (Fedora 29) / execa 1.0.0.

I just realized now that this only happens when the path to the file is absolute (it can be located anywhere).

[ehmicky]

I can reproduce:

$ touch test.sh
$ ls -l test.sh
-rw-r--r-- 1 ether ether 0 Mar 21 16:06 test.sh

Then:

const execa = require('execa')
execa('./test.sh', { input: 'foo' })

Output:

Thrown:
TypeError: Cannot read property 'end' of undefined
    at handleInput (/home/ehmicky/Desktop/execa/index.js:114:17)
    at execa (/home/ehmicky/Desktop/execa/index.js:387:2)

I am using the latest execa (1.0.0).
Node: 11.12.0
OS: Ubuntu 18.10.

[targos]

Actually, it's not only when the path is absolute:
./test.sh: crash
/test.sh: crash
test.sh: reject (no crash)

[chinesedfan]

It's a change in Node 10+. I have submitted an issue, nodejs/node#26852. Let's waiting for response. And should we add a simple check for spawned.stdin first?

[ehmicky]

PR #212 implements that simple check.

[IssueHuntBot]

@sindresorhus has rewarded $27.00 to @stroncium. See it on IssueHunt

• 💰 Total deposit: $30.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $3.00