Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the builtin category and move the missing variables to appropriate es* categories (#140) #158

Closed
wants to merge 1 commit into from

Conversation

Standard8
Copy link
Contributor

This implements what was outlined in #140. The only missing items in the es* categories were the BigInt related ones, and the globalThis.

I have put them in the es2017 section as that is the latest one there. I wasn't quite sure if that was right or not.

@Standard8
Copy link
Contributor Author

Looking at the ESLint version of the configuration file, do we actually want a es2020 section now?

https://github.com/eslint/eslint/blob/fee6acbe13cecd4c028e681e185fc6a6d6ba9452/conf/environments.js#L35

@sindresorhus
Copy link
Owner

do we actually want a es2020 section now?

Yup

@nzakas
Copy link
Collaborator

nzakas commented Feb 18, 2020

I’d prefer not to drop builtin completely. It can be generated from the other categories to keep it in sync if that’s the concern. I think it’s valuable to keep as a collection of all globals.

@brettz9
Copy link

brettz9 commented Apr 14, 2020

@Standard8 , is anything holding you back from moving the three BigInt* and globalThis to a new es2020 (and restoring the builtin section)?

@sindresorhus
Copy link
Owner

Closing for lack of response.

#140 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants