Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 8.0.0 needs git executable on install #72

Closed
ckotzbauer opened this issue Feb 13, 2018 · 4 comments
Closed

Version 8.0.0 needs git executable on install #72

ckotzbauer opened this issue Feb 13, 2018 · 4 comments

Comments

@ckotzbauer
Copy link

Since version 8.0.0 this library or one of its dependencies needs the "git" executable on npm install, which breaks several of our CI builds. I downgraded to 7.1.1 for now.

Is it possible to remove this dependency to git?

Node: 8.9.4
NPM: 5.6.0
OS: Windows Server 2016
@sindresorhus
Copy link
Owner

Caused by this one: https://github.com/mrmlnc/fast-glob/blob/16befe373e975fe6bb6ba9d1ba1006640f31f18a/package.json#L54

// @mrmlnc

@mrmlnc
Copy link
Contributor

mrmlnc commented Feb 13, 2018 •
edited
Loading

Yeap, I can publish this package as readdir-enhanced-tmp in my namespace. Unfortunately, I haven't access to readdir-enhanced package. Will be fixed today.

@mrmlnc mrmlnc mentioned this issue Feb 13, 2018
Merged
@mrmlnc
Copy link
Contributor

mrmlnc commented Feb 13, 2018 •
edited
Loading

Fixed by fast-glob@2.0.4.

@kevva
Copy link
Contributor

kevva commented Feb 14, 2018

@mrmlnc, awesome!

@kevva kevva closed this as completed Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sindresorhus @kevva @mrmlnc @ckotzbauer