Allow specifying undefined for options (#2258)

sindresorhus · May 27, 2023 · 1cefe8b · 1cefe8b
1 parent 0337311
commit 1cefe8b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/source/core/options.ts b/source/core/options.ts
@@ -1078,7 +1078,13 @@ export default class Options {
 				}
 
 				// @ts-expect-error Type 'unknown' is not assignable to type 'never'.
-				this[key as keyof Options] = options[key as keyof Options];
+				const value = options[key as keyof Options];
+				if (value === undefined) {
+					continue;
+				}
+
+				// @ts-expect-error Type 'unknown' is not assignable to type 'never'.
+				this[key as keyof Options] = value;
 
 				push = true;
 			}

diff --git a/test/agent.ts b/test/agent.ts
@@ -205,3 +205,17 @@ test('no socket hung up regression', withServer, async (t, server, got) => {
 
 	agent.destroy();
 });
+
+test('accept undefined agent', withServer, async (t, server, got) => {
+	server.get('/', (_request, response) => {
+		response.end('ok');
+	});
+
+	const undefinedAgent = undefined;
+	t.truthy((await got({
+		https: {
+			rejectUnauthorized: false,
+		},
+		agent: undefinedAgent,
+	})).body);
+});