Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer.from causes incompatibility with node 4 #241

Closed
mikemcbride opened this issue Nov 3, 2016 · 2 comments
Closed

Buffer.from causes incompatibility with node 4 #241

mikemcbride opened this issue Nov 3, 2016 · 2 comments

Comments

@mikemcbride
Copy link

Buffer.from wasn't added to Node until v5.10.0, so the changes in 5888ca7 caused this to break when running Node 4. I'm thinking the engines in package.json needs to be updated to reflect this?
@squarejaw
Copy link

Buffer.from was backported to v4.5.0, so it would be nice if that was the minimum version required.

@shinnn shinnn mentioned this issue Nov 4, 2016
Closed
@floatdrop
Copy link
Contributor

@mmcbride1007 @squarejaw future testing was added in 6.6.2 – should work on 4.x now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@floatdrop @squarejaw @mikemcbride