Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES2015 and Promises #203

Closed
sindresorhus opened this issue Aug 26, 2015 · 7 comments
Closed

ES2015 and Promises #203

sindresorhus opened this issue Aug 26, 2015 · 7 comments

Comments

@sindresorhus
Copy link
Owner

I think we should go all in on this module and use ES2015 and Promises. Need to find a way to easily compile with Babel without too much boilerplate. Promise polyfill: https://github.com/floatdrop/pinkie-promise

PR welcome if anyone wants to try their hand at this.

@kevva
Copy link
Contributor

kevva commented Oct 2, 2015

Just running babel index --out dist.js should be enough I guess.

@sindresorhus
Copy link
Owner Author

Yup, and add a "main" field in package.json that points to dist.js.

@sindresorhus
Copy link
Owner Author

Or better yet, index.src.js for the ES2015 source and index.js for the dist?

@arthurvr
Copy link

arthurvr commented Oct 3, 2015

Or better yet, index.src.js for the ES2015 source and index.js for the dist?

Personally I like dist.js more as it's very clear it's the compiled version. index.js is the first place I'd look for the actual source.

@sindresorhus
Copy link
Owner Author

Even if the other file has src in its name?

@arthurvr
Copy link

arthurvr commented Oct 3, 2015

It's up to you, but I'd generally naively type vim index.js and then spot the other file.

@sindresorhus
Copy link
Owner Author

I'm fine with either. Doesn't really matter.

kevva added a commit that referenced this issue Oct 3, 2015
kevva added a commit that referenced this issue Oct 3, 2015
kevva added a commit that referenced this issue Oct 4, 2015
kevva added a commit that referenced this issue Oct 4, 2015
kevva added a commit that referenced this issue Oct 4, 2015
kevva added a commit that referenced this issue Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants