Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob support #38

Closed
3 tasks done
sindresorhus opened this issue Oct 14, 2015 · 6 comments
Closed
3 tasks done

Add glob support #38

sindresorhus opened this issue Oct 14, 2015 · 6 comments

Comments

@sindresorhus
Copy link
Owner

Using globby.sync().

  • Add it
  • Update usage example in readme
  • Update trash-cli readme

PR welcome :)

@sotojuan
Copy link

I'll give this a shot this weekend. Doesn't seem so bad!

@sotojuan
Copy link

Question: Should the glob support be automatic or should the user supply an option? I got it working, but it doesn't match 'weird\\\\name\\"\'' because of the /s. It makes globby think it's a directory listing. Since it doesn't find one, it doesn't delete the file.

@sotojuan
Copy link

sotojuan commented Nov 2, 2015

Sorry if you're busy Sindre, but let me know what you think of this _ The "weird name" test is the only issue, assuming automatic globbing.

@sindresorhus
Copy link
Owner Author

Yes, should be just automatic. To fix the mentioned problem we should set nonull: true in globby.

https://github.com/isaacs/node-glob#comparisons-to-other-fnmatchglob-implementations

@sotojuan
Copy link

sotojuan commented Nov 2, 2015

Thanks. Expect a PR soon!

@kevva
Copy link
Contributor

kevva commented Nov 5, 2015

Fixed in ccd8d52.

@kevva kevva closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants