Add RequiredDeep type
#401
Conversation
|
note: the issue linked in the PR description points to the contribution guidelines instead of an actual issue. Is this by mistake? |
|
It’s this issue I think. |
sorry(( wrong link |
Yes you are right |
| ? ReadonlyMap<RequiredDeep<KeyType>, RequiredDeep<ValueType>> | ||
| : E extends ReadonlySet<infer ItemType> | ||
| ? ReadonlySet<RequiredDeep<ItemType>> | ||
| : E extends (arg: any[]) => unknown |
There was a problem hiding this comment.
I think there is a small typo here, this type will only match functions with a single array argument. From my (limited) testing it should actually be : E extends (...arg: any[]) => unknown to match all types of function args.
There was a problem hiding this comment.
@ilchenkoArtem Make sure you add a test for this too.
There was a problem hiding this comment.
I wil fix this it this week
|
Make sure you look at our existing "deep" types and that this new types handles all the cases handled by them. For example, type-fest/source/readonly-deep.d.ts Line 80 in 2f418db |
| type ExcludeUndefined<T> = Exclude<T, undefined>; | ||
|
|
||
| /** | ||
| Create a type from another type with all keys and nested keys set to optional. |
There was a problem hiding this comment.
Make sure the docs are correct.
| interface FooRequired { | ||
| baz: string; | ||
| bar: { | ||
| function: (...args: any[]) => void; |
There was a problem hiding this comment.
| function: (...args: any[]) => void; | |
| function: (...arguments: any[]) => void; |
There was a problem hiding this comment.
The term arguments is not allowed when TypeScript is in strict mode anymore, if it ever way.
|
CI is failing |
| } | ||
| ``` | ||
|
|
||
| @category Utilities |
There was a problem hiding this comment.
type-fest/source/partial-deep.d.ts
Lines 31 to 34 in 2f418db
|
Friendly bump :) |
soory, I am not having time now(( I am having a lot of work( |
|
Closing for lack of activity. |
Fixes #273